Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Certificate glossary term #7456

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Add Certificate glossary term #7456

merged 2 commits into from
Feb 20, 2018

Conversation

sdague
Copy link
Contributor

@sdague sdague commented Feb 20, 2018 •
edited
Loading

Part of issue #5993

Allow edits from maintainers checkbox

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2018
@sdague sdague force-pushed the glossary_certificate branch from c8de5c6 to 2999938 Compare February 20, 2018 19:00
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c8de5c6

https://deploy-preview-7456--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Feb 20, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 17605cd

https://deploy-preview-7456--kubernetes-io-master-staging.netlify.com

@sdague
Copy link
Contributor Author

sdague commented Feb 20, 2018

recheck cla

@sdague sdague closed this Feb 20, 2018
@sdague sdague reopened this Feb 20, 2018
@sdague sdague closed this Feb 20, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 20, 2018
@sdague sdague reopened this Feb 20, 2018
bradtopol
bradtopol reviewed Feb 20, 2018
View reviewed changes
_data/glossary/certificate.yaml Outdated
tags:
- security
short-description: >
A crytographicly secure file used to validate access to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix typo: crytographicly

bradtopol
bradtopol previously requested changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@bradtopol bradtopol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo: crypographicly

please fix

@zacharysarah zacharysarah dismissed bradtopol’s stale review February 20, 2018 19:26

Resolved concerns with direct edits

@zacharysarah
Copy link
Contributor

@sdague Great first PR, looks good to me. :shipit:

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5e0e6e9 into kubernetes:master Feb 20, 2018
tengqm
tengqm reviewed Feb 21, 2018
View reviewed changes
_data/glossary/certificate.yaml
@@ -0,0 +1,11 @@
id: certificate
name: Certificate
full-link: https://kubernetes.io/docs/tasks/tls/managing-tls-in-a-cluster/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the "https://kubernetes.io" part?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, fix in - #7476

bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
@sdague @bsalamat
Add Certificate glossary term (kubernetes#7456)
630ef7a 
* Add Certificate glossary term

Part of issue kubernetes#5993

* Edits for clarity
tehut pushed a commit to tehut/website that referenced this pull request Mar 8, 2018
@sdague @tehut
Add Certificate glossary term (kubernetes#7456)
b48fd7a 
* Add Certificate glossary term

Part of issue kubernetes#5993

* Edits for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@bradtopol bradtopol bradtopol left review comments

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sdague @k8s-ci-robot @k8sio-netlify-preview-bot @zacharysarah @tengqm @bradtopol