Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3857: promote RecursiveReadOnlyMounts feature to beta #48615

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

AkihiroSuda
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 1, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2024
Copy link

netlify bot commented Nov 1, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ad275f5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67280ddd26c04600081bc722
😎 Deploy Preview https://deploy-preview-48615--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Nov 2, 2024

dup of #47852

The gate has reached beta in v1.31.
refs:
- https://kep.k8s.io/3857
- k/k PR 125475

Fix issue 48614

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Member Author

#47852

47852 seems stalled, any chance to just merge this PR?

@tengqm
Copy link
Contributor

tengqm commented Nov 4, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c2c8723094eaa82b9bf80f226697aa88f469ec02

@k8s-ci-robot k8s-ci-robot merged commit 7b2db50 into kubernetes:main Nov 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Feature Gates" page says RecursiveReadOnly is still alpha, although it is actually beta
4 participants