Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEP-3960] - update docs for GA #48295

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented Oct 12, 2024

Description

Document PodLifecycleSleepAction for GA

Issue

GA doc requirement for KEP-3960

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 12, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 12, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from thockin October 12, 2024 02:58
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2024
Copy link

netlify bot commented Oct 12, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 563032e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/672988992c8e7800081f0ae8

Copy link

netlify bot commented Oct 12, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 563032e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67298899841d7600089a14dd
😎 Deploy Preview https://deploy-preview-48295--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AxeZhan AxeZhan marked this pull request as ready for review November 5, 2024 03:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@AxeZhan
Copy link
Member Author

AxeZhan commented Nov 5, 2024

@thockin Should this be enough? As there's no new feature changes.

Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 014a90b629b9658e166781ce6034eab35f1f6cbf

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream k/k code changes are merged as part of kubernetes/kubernetes#128046

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4d65a6b into kubernetes:dev-1.32 Nov 6, 2024
6 checks passed
k8s-ci-robot added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants