add a blog to introduce about kubeadm v1beta4 #47248

pacoxu · 2024-07-24T08:12:28Z

netlify · 2024-07-24T08:20:34Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`00df7f2`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a0b76ebb251f0008053551
😎 Deploy Preview	https://deploy-preview-47248--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-07-24T08:28:04Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`b3629ec`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66ac40d2c4c04a0008ac2bad
😎 Deploy Preview	https://deploy-preview-47248--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

tengqm · 2024-07-24T12:23:49Z

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

+- For ClusterConfiguration, we add field including `CertificateValidityPeriod`, `CACertificateValidityPeriod`, `EncryptionAlgorithm`, `DNS.Disabled` and `Proxy.Disabled`.
+- Support `ExtraEnvs` for all control plan components
+- `ExtraArgs` changed from a map to structured extra arguments for duplicates
+- Add a `Timeouts` structure for init, join, upgrade and reset.


Please always use the user-facing field names rather than the Go field names when possible. For example, say "imagePullSerial" instead of "ImagePullSerial".

/cc @neolit123
Do we want to change the style here?

In https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta3/, the changes docs are using go fields like the release notes.

In https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta3/#resource-types and below, we use the user-facing field names.

For clarification's purpose. The config API reference is NOT generated directly from the k/k repository for two reasons:

The package in k/k/cmd/kubeadm is not importable from an external project.

The comments in the source code are not documenting fields in the way users see them.

What you are reading from k/website is generated from github.com/tengqm/kubeconfig repo, where I manually copied the kubeadm api repository and manually synchronize whatever changes made to k/k/cmd/kubeadm/api.

The "changes" doc are using Go fields because I failed to perform a line-by-line checking when that API was introduced.

Please always use the user-facing field names rather than the Go field names when possible. For example, say "imagePullSerial" instead of "ImagePullSerial".

i don't mind this format of using the JSON tags. this is something the docs team has been recommending to us on the blog and web pages and i agree with it.

Do we want to change the style here?

however for the style in the go.doc, that's also targeting developers, so i think field names also work.
we could make it simpler to use JSON field names everywhere. but that's like something we can do after 1.31 or another time.

I add 41b8f05 to make most places using user facing field names.

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

neolit123

added a few minor comments, but LGTM
thanks for adding this blog @pacoxu

/sig cluster-lifecycle

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

neolit123 · 2024-07-25T10:48:30Z

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

+- For ClusterConfiguration, we add field including `CertificateValidityPeriod`, `CACertificateValidityPeriod`, `EncryptionAlgorithm`, `DNS.Disabled` and `Proxy.Disabled`.
+- Support `ExtraEnvs` for all control plan components
+- `ExtraArgs` changed from a map to structured extra arguments for duplicates
+- Add a `Timeouts` structure for init, join, upgrade and reset.


Please always use the user-facing field names rather than the Go field names when possible. For example, say "imagePullSerial" instead of "ImagePullSerial".

i don't mind this format of using the JSON tags. this is something the docs team has been recommending to us on the blog and web pages and i agree with it.

Do we want to change the style here?

however for the style in the go.doc, that's also targeting developers, so i think field names also work.
we could make it simpler to use JSON field names everywhere. but that's like something we can do after 1.31 or another time.

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

sftim

Thanks. As you'll see in the inline feedback, I recommend calling this thing a “configuration file format“ (and not an API). API implies that something is invoking remote procedures to reconfigure kubeadm, and that's not what we're describing here.

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

sftim · 2024-07-27T16:46:02Z

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

+The documentation is maintained in the
+[code](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1beta4/doc.go)
+and generated for the kubernetes.io website.


I don't think readers will want to know this detail.

Suggested change

The documentation is maintained in the

[code](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1beta4/doc.go)

and generated for the kubernetes.io website.

OK to remove this. But for kube contributors, this is still a thing that they should know.

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

sftim · 2024-07-27T16:49:20Z

/hold

OK to unhold once:

the publication date is agreed with release comms, and is correct in the front matter
Kubernetes v1.31 has been released

(wait for both conditions to be met)

sftim

This feedback is less important, but will help readers clearly understand what we are explaining.

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

sftim · 2024-07-27T16:57:12Z

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

+- Add a `certificateValidityPeriod` and `caCertificateValidityPeriod` fields to `ClusterConfiguration`. These fields
+can be used to control the validity period of certificates generated by kubeadm during sub-commands such as `init`,
+`join`, `upgrade` and `certs`. Default values continue to be 1 year for non-CA certificates and 10 years for CA
+certificates. Only non-CA certificates continue to be renewable by `kubeadm certs renew`.


That last sentence confuses me. Which of these do we mean:

there is no change to which certificates you can renew using kubeadm certs renew; as in previous minor releases, only leaf certificates can be renewed.

changed the behavior of kubeadm certs renew. In kubeadm v1.31, you can only renew leaf certificates; if you need to renew or replace any CA certificate (either the trust anchor or an intermediate certificate), you must now find an alternative mechanism.

Let's help readers by rewording, so that only one meaning makes sense.

The first one.

No behavior change here.

tengqm · 2024-07-29T12:25:27Z

/lgtm

k8s-ci-robot · 2024-07-29T12:25:34Z

LGTM label has been added.

Git tree hash: bffe6fc6ec20be5442b7dafb287e65d8ceac0182

sftim · 2024-08-02T02:08:30Z

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md

Filename nit; did you mean content/en/blog/_posts/2024-08-23-kubeadm-v1beta4.md?

Missed that one. Fixed.

sftim · 2024-08-02T09:29:44Z

/lgtm
/approve

🛑 Do not unhold until Kubernetes v1.31 is released 🛑

k8s-ci-robot · 2024-08-02T09:29:50Z

LGTM label has been added.

Git tree hash: 062f7ae1cb5828b48dc16824f6eef4025ac4c953

sftim · 2024-08-02T09:29:55Z

🛑 Do not unhold until Kubernetes v1.31 is released 🛑

SataQiu

/approve
/lgtm

k8s-ci-robot · 2024-08-12T09:00:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/blog/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dipesh-rawat · 2024-08-13T16:50:15Z

/unhold

Kubernetes v1.31 has been released.

k8s-ci-robot requested review from nate-double-u and sftim July 24, 2024 08:12

pacoxu marked this pull request as ready for review July 24, 2024 08:13

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2024

k8s-ci-robot requested a review from Gauravpadam July 24, 2024 08:14

pacoxu force-pushed the kubeadm-v1beta4 branch from 00df7f2 to d13d416 Compare July 24, 2024 08:16

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2024

windsonsea reviewed Jul 24, 2024

View reviewed changes

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md Outdated Show resolved Hide resolved

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md Outdated Show resolved Hide resolved

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md Outdated Show resolved Hide resolved

tengqm reviewed Jul 24, 2024

View reviewed changes

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md Outdated Show resolved Hide resolved

tengqm reviewed Jul 24, 2024

View reviewed changes

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md Outdated Show resolved Hide resolved

tengqm reviewed Jul 24, 2024

View reviewed changes

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md Outdated Show resolved Hide resolved

tengqm reviewed Jul 24, 2024

View reviewed changes

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md Outdated Show resolved Hide resolved

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md Outdated Show resolved Hide resolved

pacoxu force-pushed the kubeadm-v1beta4 branch from d13d416 to d38cd96 Compare July 25, 2024 03:26

k8s-ci-robot requested a review from neolit123 July 25, 2024 03:28

pacoxu mentioned this pull request Jul 25, 2024

fix a typo in kubeadm v1beta4 doc kubernetes/kubernetes#126324

Merged

neolit123 reviewed Jul 25, 2024

View reviewed changes

k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 25, 2024

add a blog to introduce about kubeadm v1beta4

bb82979

pacoxu force-pushed the kubeadm-v1beta4 branch from d38cd96 to bb82979 Compare July 25, 2024 13:43

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2024

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2024

Ritikaa96 suggested changes Jul 26, 2024

View reviewed changes

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md Outdated Show resolved Hide resolved

content/en/blog/_posts/2024-09-20-kubeadm-v1beta4.md Outdated Show resolved Hide resolved

sftim reviewed Jul 27, 2024

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2024

sftim reviewed Jul 27, 2024

View reviewed changes

k8s-ci-robot assigned tengqm Jul 29, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024

sftim reviewed Aug 2, 2024

View reviewed changes

address Tim's comments: mainly use file format instead of API

b3629ec

pacoxu force-pushed the kubeadm-v1beta4 branch from e5cd0b9 to b3629ec Compare August 2, 2024 02:13

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2024

k8s-ci-robot requested a review from tengqm August 2, 2024 02:13

k8s-ci-robot assigned sftim Aug 2, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024

pacoxu mentioned this pull request Aug 12, 2024

fix a typo in kubeadm v1beta4 doc kubernetes/kubernetes#126628

Merged

SataQiu reviewed Aug 12, 2024

View reviewed changes

k8s-ci-robot assigned SataQiu Aug 12, 2024

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024

k8s-ci-robot merged commit 5a283be into kubernetes:main Aug 13, 2024
6 checks passed

inductor mentioned this pull request Aug 28, 2024

Fix doc link #47714

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a blog to introduce about kubeadm v1beta4 #47248

add a blog to introduce about kubeadm v1beta4 #47248

pacoxu commented Jul 24, 2024 •

edited

Loading

netlify bot commented Jul 24, 2024

netlify bot commented Jul 24, 2024 •

edited

Loading

tengqm Jul 24, 2024

pacoxu Jul 25, 2024

tengqm Jul 25, 2024

neolit123 Jul 25, 2024

pacoxu Jul 25, 2024

neolit123 left a comment

neolit123 Jul 25, 2024

sftim left a comment

sftim Jul 27, 2024

pacoxu Jul 29, 2024

sftim commented Jul 27, 2024 •

edited

Loading

sftim left a comment

sftim Jul 27, 2024

pacoxu Jul 29, 2024

tengqm commented Jul 29, 2024

k8s-ci-robot commented Jul 29, 2024

sftim Aug 2, 2024

pacoxu Aug 2, 2024 •

edited

Loading

sftim commented Aug 2, 2024

k8s-ci-robot commented Aug 2, 2024

sftim commented Aug 2, 2024

SataQiu left a comment

k8s-ci-robot commented Aug 12, 2024

dipesh-rawat commented Aug 13, 2024

	The documentation is maintained in the
	[code](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1beta4/doc.go)
	and generated for the kubernetes.io website.

add a blog to introduce about kubeadm v1beta4 #47248

add a blog to introduce about kubeadm v1beta4 #47248

Conversation

pacoxu commented Jul 24, 2024 • edited Loading

netlify bot commented Jul 24, 2024

✅ Pull request preview available for checking

netlify bot commented Jul 24, 2024 • edited Loading

✅ Pull request preview available for checking

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neolit123 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sftim commented Jul 27, 2024 • edited Loading

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tengqm commented Jul 29, 2024

k8s-ci-robot commented Jul 29, 2024

Choose a reason for hiding this comment

pacoxu Aug 2, 2024 • edited Loading

Choose a reason for hiding this comment

sftim commented Aug 2, 2024

k8s-ci-robot commented Aug 2, 2024

sftim commented Aug 2, 2024

🛑 Do not unhold until Kubernetes v1.31 is released 🛑

SataQiu left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 12, 2024

dipesh-rawat commented Aug 13, 2024

pacoxu commented Jul 24, 2024 •

edited

Loading

netlify bot commented Jul 24, 2024 •

edited

Loading

sftim commented Jul 27, 2024 •

edited

Loading

pacoxu Aug 2, 2024 •

edited

Loading