Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: start using v1beta4 in all docs #47103

Merged
merged 2 commits into from
Jul 7, 2024
Merged

kubeadm: start using v1beta4 in all docs #47103

merged 2 commits into from
Jul 7, 2024

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Jul 5, 2024 •
edited
Loading

  • make some updates to --config on upgrade, as now it supports an v1beta4,UpgradeConfiguration and there is no possibility to reconfigure using --config on upgrade anymore.
  • start using v1beta4 in all examples, the v1beta4 API page is already generated but needs update for 1.31.

xref kubernetes/kubeadm#2890

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jul 5, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 5, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 5, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit efc1133
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6687f419c9d7950008507b9b

@k8s-ci-robot k8s-ci-robot requested review from jbeda and sftim July 5, 2024 13:12
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 5, 2024
neolit123
neolit123 commented Jul 5, 2024
View reviewed changes
content/en/docs/setup/production-environment/tools/kubeadm/control-plane-flags.md
kind: ClusterConfiguration
kubernetesVersion: v1.16.0
apiServer:
extraArgs:
anonymous-auth: "false"
Copy link
Member Author

@neolit123 neolit123 Jul 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this flag from the example as kubeadm doesn't really support it well.

neolit123
neolit123 commented Jul 5, 2024
View reviewed changes
Copy link
Member Author

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @SataQiu @pacoxu
/sig cluster-lifecycle
/kind feature

@k8s-ci-robot k8s-ci-robot requested review from pacoxu and SataQiu July 5, 2024 13:13
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 5, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 5, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit efc1133
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6687f419a94ffc00089d9397
😎 Deploy Preview https://deploy-preview-47103--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@neolit123 neolit123 force-pushed the 1.31-remove-note-about-upgrade-config branch 2 times, most recently from 33e044e to 8658714 Compare July 5, 2024 13:22
@neolit123 neolit123 force-pushed the 1.31-remove-note-about-upgrade-config branch from 8658714 to efc1133 Compare July 5, 2024 13:24
@tengqm
Copy link
Contributor

tengqm commented Jul 6, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2024
Arhell
Arhell reviewed Jul 6, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SataQiu
SataQiu reviewed Jul 7, 2024
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f77fb762c328014b3215e9d90e62cb5dd1635c76

@k8s-ci-robot k8s-ci-robot merged commit dea8689 into kubernetes:dev-1.31 Jul 7, 2024
6 checks passed
@SsomsakTH SsomsakTH mentioned this pull request Jul 7, 2024
Closed
@t-inu t-inu mentioned this pull request Aug 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu left review comments

@Arhell Arhell Arhell left review comments

@jbeda jbeda Awaiting requested review from jbeda

@sftim sftim Awaiting requested review from sftim

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
5 participants
@neolit123 @tengqm @k8s-ci-robot @SataQiu @Arhell