-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4033: cgroup driver from CRI beta blog #47054
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @haircommander thanks for your interest in contributing a blog for 1.31. Please update this to target the /hold Pending assignment of publication date (by release comms) We'll also keep this held until the v1.31 release has happened |
Hello! I'm Rashan, from the 1.31 Release comms team. I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024. Please let me know how we can help! |
Hello @haircommander today is our ready for review deadline for blog content for 1.31. Are you still interested in writing a blog for this feature? If so please let us know. This blog publication is scheduled for August 21. and this PR should target the cc: @rashansmith |
c119b13
to
6e6e556
Compare
Hello @haircommander, Is your blog ready for review? If so, please let us know. cc: @a-mccarthy |
yes this is ready! |
/hold cancel |
layout: blog | ||
title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | ||
date: 2024-07-01 | ||
slug: cgroup driver from CRI to betra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
slug: cgroup driver from CRI to betra | |
slug: cgroup driver from CRI to beta |
6e6e556
to
d2b585f
Compare
thanks @divya-mohan0209 updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Here's a second batch of comments. WDYT?
Would appreciate a second pair of eyes on this one and shall socialise on the sig docs blog channel.
--- | ||
layout: blog | ||
title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | ||
date: 2024-08-06 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-mccarthy : Is this the correct date for publication? If not, please could you confirm what this needs to be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the filename, I'm guessing it should be 2024-08-21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #47054 (comment)
date: 2024-08-06 | |
date: 2024-08-21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still hasn't been resolved in the commit visible to me. Please can we update it to the latest date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve cancel
to highlight the problem
See https://github.com/kubernetes/website/pull/47054/files#r1720753283
|
||
## `KubeletCgroupDriverFromCRI` Feature Gate | ||
|
||
In v1.28.0, the SIG Node community introduced the feature gate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In v1.28.0, the SIG Node community introduced the feature gate | |
In v1.28.0, the SIG Node community introduced the [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) |
feature is now beta! | ||
|
||
In addition to setting the feature gate, a cluster admin needs to ensure their | ||
CRI implementatikn is new enough: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current statement is likely to confuse users, as they might think they need to be on the latest version of the CRI for this to work. From the information given below, it would make more sense to say supported instead of new enough.
CRI implementatikn is new enough: | |
CRI implementation is new enough: |
I think that excluding your comments (I think they should be incorporated) it looks good! |
@@ -0,0 +1,38 @@ | |||
--- | |||
layout: blog | |||
title: "Configuring Kubernetes just got easier: cgroup driver from CRI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this needs to follow title casing per our style guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | |
title: "Kubernetes v1.31: Autoconfiguration For Node Cgroup Driver (beta)" |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm cancel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More feedback
layout: blog | ||
title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | ||
date: 2024-08-21 | ||
slug: cgroup driver from CRI to beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slug: cgroup driver from CRI to beta | |
slug: cri-cgroup-driver-lookup-now-beta |
the same cgroup driver, or else the kubelet would exit with an error. This was a | ||
source of headaches for many cluster admins. However, there is light at the end of the tunnel! | ||
|
||
## `KubeletCgroupDriverFromCRI` Feature Gate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## `KubeletCgroupDriverFromCRI` Feature Gate | |
## Automated CRI driver configuration |
or, less ideal
## `KubeletCgroupDriverFromCRI` Feature Gate | |
## `KubeletCgroupDriverFromCRI` feature gate |
Then, they should ensure their CRI implementation is configured to the | ||
`cgroup_driver` they would like to use. | ||
|
||
## Future Work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Future Work | |
## Future work |
- containerd: Support has been added in v2.0.0 | ||
- CRI-O: Support has been added in v1.28.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- containerd: Support has been added in v2.0.0 | |
- CRI-O: Support has been added in v1.28.0 | |
- containerd: Support was added in v2.0.0 | |
- CRI-O: Support was added in v1.28.0 |
@@ -0,0 +1,38 @@ | |||
--- | |||
layout: blog | |||
title: "Configuring Kubernetes just got easier: cgroup driver from CRI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: "Configuring Kubernetes just got easier: cgroup driver from CRI" | |
title: "Kubernetes v1.31: Autoconfiguration For Node Cgroup Driver (beta)" |
39dcae8
to
3095156
Compare
updated thanks! |
3095156
to
8762893
Compare
Signed-off-by: Peter Hunt <[email protected]>
8762893
to
0bc5734
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 3033422e01cc20ed4528525b99bd21a7600e5074
|
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.