Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate KubeProxyDrainingTerminatingNodes to GA #47048

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Graduate KubeProxyDrainingTerminatingNodes to GA #47048

merged 2 commits into from
Jul 7, 2024

Conversation

alexanderConstantinescu
Copy link
Member

Enhancement: kubernetes/enhancements#3836

Original implementation PR: kubernetes/kubernetes#116470

Original doc PR: #45678

Superseedes: #47030

/sig network
/cc @aojea

@k8s-ci-robot k8s-ci-robot requested a review from aojea July 1, 2024 11:40
@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jul 1, 2024
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 1, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 47920ec
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6682a46badfc860008cad2c0

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 1, 2024
@aojea aojea mentioned this pull request Jul 1, 2024
Closed
@alexanderConstantinescu alexanderConstantinescu mentioned this pull request Jul 1, 2024
Open
12 tasks
@netlify Netlify
Copy link

netlify bot commented Jul 1, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 47920ec
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6682a46a6f98430008da075b
😎 Deploy Preview https://deploy-preview-47048--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shubham82
Copy link
Contributor

Shubham82 commented Jul 1, 2024 •
edited
Loading

Thanks @alexanderConstantinescu for the PR
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0930f4fdbf173fb9715569a99916b0797dc53a1

@Shubham82
Copy link
Contributor

/retitle Graduate KubeProxyDrainingTerminatingNodes to GA

@k8s-ci-robot k8s-ci-robot changed the title KEP-3836 - v1.31 doc update Graduate KubeProxyDrainingTerminatingNodes to GA Jul 1, 2024
@alexanderConstantinescu @dipesh-rawat
Update content/en/docs/reference/command-line-tools-reference/feature…
47920ec 
…-gates/kube-proxy-draining-terminating-nodes.md

Co-authored-by: Dipesh Rawat <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Shubham82 July 1, 2024 12:43
@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 22ffda7419d8dc302e0b1343c5934f3ec0410bd0

@kundan2707
Copy link
Contributor

Thanks for change
/lgtm

dipesh-rawat
dipesh-rawat reviewed Jul 7, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1bd4e5c into kubernetes:dev-1.31 Jul 7, 2024
6 checks passed
@SsomsakTH SsomsakTH mentioned this pull request Jul 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@aojea aojea Awaiting requested review from aojea

@Shubham82 Shubham82 Awaiting requested review from Shubham82

Assignees

@Shubham82 Shubham82

@kundan2707 kundan2707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
5 participants
@alexanderConstantinescu @Shubham82 @k8s-ci-robot @kundan2707 @dipesh-rawat