Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs update for k8s 1.31 regarding Service trafficDistribution #46973

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Docs update for k8s 1.31 regarding Service trafficDistribution #46973

merged 1 commit into from
Jul 16, 2024
+4 −0

Conversation

gauravkghildiyal
Copy link
Member

@gauravkghildiyal gauravkghildiyal commented Jun 25, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jun 25, 2024
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 9f6bbb6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66959da4d7b24700081cf213

This was referenced Jun 25, 2024
Open
Closed
@k8s-ci-robot k8s-ci-robot requested a review from katcosgrove June 25, 2024 18:19
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 25, 2024
@k8s-ci-robot k8s-ci-robot requested a review from salaxander June 25, 2024 18:19
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f6bbb6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66959da4bcc8ca0008cfb8b9
😎 Deploy Preview https://deploy-preview-46973--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jun 27, 2024

/retitle [WIP] Docs update for k8s 1.31 regarding Service trafficDistribution

@k8s-ci-robot k8s-ci-robot changed the title Placeholder: Docs update for k8s 1.31 regarding Service trafficDistribution [WIP] Docs update for k8s 1.31 regarding Service trafficDistribution Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2024
@Princesso
Copy link
Contributor

Hello @gauravkghildiyal 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

@Princesso
Copy link
Contributor

Hi @gauravkghildiyal, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 15, 2024
@gauravkghildiyal gauravkghildiyal changed the title [WIP] Docs update for k8s 1.31 regarding Service trafficDistribution Docs update for k8s 1.31 regarding Service trafficDistribution Jul 15, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
@gauravkghildiyal
Copy link
Member Author

This is ready for review!

@tengqm
Copy link
Contributor

tengqm commented Jul 15, 2024

/approve
/hold
Please confirm that the feature-gates file is the only file that needs a change following this upgrade to Beta, and then lift the hold.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@tengqm
Copy link
Contributor

tengqm commented Jul 15, 2024

@gauravkghildiyal Please provide the link to the upstream code change, thanks.

@gauravkghildiyal
Copy link
Member Author

@gauravkghildiyal Please provide the link to the upstream code change, thanks.

Hi @tengqm, updated the PR description with the same. Also, here's the requested links:

Code changes for promotion to beta: kubernetes/kubernetes#125838
KEP: kubernetes/enhancements#4444

@gauravkghildiyal
Copy link
Member Author

Confirming #46973 (comment)

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@katcosgrove
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 60103a0946d8f6475d9316945a6d61845d997075

@k8s-ci-robot k8s-ci-robot merged commit 81544d5 into kubernetes:dev-1.31 Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@katcosgrove katcosgrove

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
6 participants
@gauravkghildiyal @sftim @Princesso @tengqm @k8s-ci-robot @katcosgrove