-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nftables kube-proxy docs for 1.31 beta #46541
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/sig network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed multiple command line flags in the content but shouldn't we encourage users to use v1alpha1 config instead of command line flags (given config precede flag)?
Maybe we can include the min-supported kernel version as well?
Otherwise LGTM.
I think we're currently inconsistent about that, but generally, given that the config is alpha and the CLI is not, I think the command line flags are preferred for documentation? I'm not really sure though...
Yes, good point, though that hasn't actually merged yet. |
the config is alpha in name but any incompatible change there will break a lot of clients Nice write up /lgtm |
LGTM label has been added. Git tree hash: c88b819972556f68d00382b977e0aa3fab8ceb2e
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: 4f9c888321c7e19d36dfae5bb0ef87df56c35b2b
|
@aojea @aroradaman Am I forgetting any other iptables→nftables changes that need to be documented?