Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nftables kube-proxy docs for 1.31 beta #46541

Merged
merged 1 commit into from
May 28, 2024

Conversation

danwinship
Copy link
Contributor

@aojea @aroradaman Am I forgetting any other iptables→nftables changes that need to be documented?

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone May 25, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2024
Copy link

netlify bot commented May 25, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit e6de84d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6655cb99cc2cb10009c6d9b4

@k8s-ci-robot k8s-ci-robot requested a review from mickeyboxell May 25, 2024 13:45
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 25, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 25, 2024
Copy link

netlify bot commented May 25, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e6de84d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6655cb9959adf40008d79dd5
😎 Deploy Preview https://deploy-preview-46541--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label May 25, 2024
Copy link
Member

@aroradaman aroradaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed multiple command line flags in the content but shouldn't we encourage users to use v1alpha1 config instead of command line flags (given config precede flag)?

Maybe we can include the min-supported kernel version as well?

Otherwise LGTM.

@danwinship
Copy link
Contributor Author

shouldn't we encourage users to use v1alpha1 config instead of command line flags (given config precede flag)

I think we're currently inconsistent about that, but generally, given that the config is alpha and the CLI is not, I think the command line flags are preferred for documentation? I'm not really sure though...

Maybe we can include the min-supported kernel version as well?

Yes, good point, though that hasn't actually merged yet.

@aojea
Copy link
Member

aojea commented May 27, 2024

given that the config is alpha

the config is alpha in name but any incompatible change there will break a lot of clients

Nice write up

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c88b819972556f68d00382b977e0aa3fab8ceb2e

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from aojea May 28, 2024 12:18
@tengqm
Copy link
Contributor

tengqm commented May 28, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@aroradaman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f9c888321c7e19d36dfae5bb0ef87df56c35b2b

@k8s-ci-robot k8s-ci-robot merged commit 777c6e3 into kubernetes:dev-1.31 May 28, 2024
6 checks passed
@danwinship danwinship deleted the nftables-beta branch May 28, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants