Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Update reference to CNCF landscape (v2) in 'Training' page #46019

Merged
merged 1 commit into from
Apr 28, 2024
Merged

[hi] Update reference to CNCF landscape (v2) in 'Training' page #46019

merged 1 commit into from
Apr 28, 2024

Conversation

niranjandarshann
Copy link
Contributor

Updated [hi] Invalid Link of Kubernetes Training Partners in training page. #46018

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Babapool April 25, 2024 08:52
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added the language/hi Issues or PRs related to Hindi language label Apr 25, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 25, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 130f22c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/662a199f8732d30008e737a0
😎 Deploy Preview https://deploy-preview-46019--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@niranjandarshann
Copy link
Contributor Author

Please find the deployment preview :
https://deploy-preview-46019--kubernetes-io-main-staging.netlify.app/hi/training/

dipesh-rawat
dipesh-rawat reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 92e0789f50335ba2169c4f3d3fab044f84e57223

@dipesh-rawat
Copy link
Member

/retitle [hi] Update reference to CNCF landscape (v2) in 'Training' page

For added clarity.

@k8s-ci-robot k8s-ci-robot changed the title updated the k8s training partner with valid link [hi] Update reference to CNCF landscape (v2) in 'Training' page Apr 25, 2024
divya-mohan0209
divya-mohan0209 reviewed Apr 28, 2024
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5f18480 into kubernetes:main Apr 28, 2024
6 checks passed
@divya-mohan0209 divya-mohan0209 linked an issue Apr 28, 2024 that may be closed by this pull request
[hi] Invalid Link of Kubernetes Training Partners in training page. #46018
Closed
@niranjandarshann niranjandarshann mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@Babapool Babapool Awaiting requested review from Babapool

Assignees

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hi] Invalid Link of Kubernetes Training Partners in training page.
4 participants
@niranjandarshann @k8s-ci-robot @dipesh-rawat @divya-mohan0209