Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add PriorityClass in glossary #45608

Merged
merged 5 commits into from
Apr 2, 2024
Merged

feat: Add PriorityClass in glossary #45608

merged 5 commits into from
Apr 2, 2024

Conversation

sergeyshevch
Copy link
Member

Hello! This PR address issue #41943. As I see both previous PR is stale and closed. This PR based on #41972 with all comments addressed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7ff6bbb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/660acd12a4a13a0009df3376
😎 Deploy Preview https://deploy-preview-45608--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

content/en/docs/reference/glossary/priority-class.md Outdated

<!-- more -->
The PriorityClass is a non-namespaced object mapping a name to an integer priority. The name is
specified in the name field, and the priority value in the value field. Priorities range from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
specified in the name field, and the priority value in the value field. Priorities range from
specified in the `metadata.name` field, and the priority value in the `value` field. Priorities range from

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0ec98e170933530d4575af75216605a19aea9662

@sergeyshevch
Copy link
Member Author

@sftim Do we need to also add some links to this glossary page somewhere or it will be better to address it in different PR

I didn't found any guideline about glossary shortcode usage

@natalisucks
Copy link
Contributor

@sergeyshevch adding links elsewhere to this glossary page can definitely be addressed in a different PR, thanks!

Once the changes Tim has suggested are applied, we can approve this merge

@sftim
Copy link
Contributor

sftim commented Mar 21, 2024

(I'm even OK with merging this without the suggested tweak, honestly - it's just good to have the glossary entry)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim March 25, 2024 17:05
sftim
sftim reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

content/en/docs/reference/glossary/priority-class.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a7f404f99ab6552618cecb64abbad7c309d80be7

@sftim
Copy link
Contributor

sftim commented Apr 1, 2024

Let's focus on getting this merged.

@sergeyshevch sergeyshevch mentioned this pull request Apr 1, 2024
Closed
9 tasks
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim April 1, 2024 15:04
@sftim
Copy link
Contributor

sftim commented Apr 1, 2024

/lgtm

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 15f23357cfe19e1067defa009561710eac147003

dipesh-rawat
dipesh-rawat reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glossary entry renders fine in the preview now.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1f95dc8 into kubernetes:main Apr 2, 2024
6 checks passed
@mrgiles mrgiles mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@natalisucks natalisucks Awaiting requested review from natalisucks

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sergeyshevch @k8s-ci-robot @natalisucks @sftim @dipesh-rawat