Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bn] Update OWNERS_ALIASES #45400

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[bn] Update OWNERS_ALIASES #45400

merged 1 commit into from
Mar 11, 2024

Conversation

asem-hamid
Copy link
Contributor

@asem-hamid asem-hamid commented Feb 29, 2024 •
edited
Loading

joining the sig-docs-bn reviewer and approver team.

/cc @a-mccarthy

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 29, 2024
@a-mccarthy
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 38492ce48b866a9427ee44a58496adad0faab351

@a-mccarthy
Copy link
Contributor

@Imtiaz1234 @mitul3737 @rajibmitra If you are around, please also review this PR for adding @asem-hamid as a review/approver for the Bengali localization 🚀

@mitul3737
Copy link
Member

@asem-hamid kindly refer to @sftim . Only he can approve this one.

@asem-hamid
Copy link
Contributor Author

@sftim Please approve this PR .

@sftim
Copy link
Contributor

sftim commented Mar 7, 2024

@asem-hamid kindly refer to @sftim . Only he can approve this one.

I don't think that's right.

@sftim
Copy link
Contributor

sftim commented Mar 7, 2024

I am one of the people who can approve this. However, let's check something. @asem-hamid are you joining as a reviewer or an approver? (there's a difference)

@asem-hamid
Copy link
Contributor Author

@sftim both

sftim
sftim reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable to do this

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Imtiaz1234, mitul3737, rajibmitra, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4b57668 into kubernetes:dev-1.24-bn.1 Mar 11, 2024
2 checks passed
@asem-hamid asem-hamid deleted the bn]-updating-OWNERS_ALIASES-for-bangla branch March 11, 2024 11:32
@asem-hamid asem-hamid mentioned this pull request Apr 3, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@Imtiaz1234 Imtiaz1234 Imtiaz1234 approved these changes

@mitul3737 mitul3737 mitul3737 approved these changes

@rajibmitra rajibmitra rajibmitra approved these changes

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@a-mccarthy a-mccarthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@asem-hamid @a-mccarthy @k8s-ci-robot @mitul3737 @sftim @rajibmitra @Imtiaz1234