-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'skew' shortcode to determine patch version accurately #45018
Fix 'skew' shortcode to determine patch version accurately #45018
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/area web-development |
/retitle Fix 'skew' shortcode to determine patch version accurately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. I've validated them on my system and they work as expected.
Additionally, I've verified the type of $currentVersion
using {{ printf "%T" $currentVersion }}
, confirming it returns a string, which aligns with the issue's root cause of formatting the string type text as a float. Great work!
/lgtm
LGTM label has been added. Git tree hash: 08ad757982081e049916e7e0b8c35a5d96aaf248
|
changes look good on my system |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR address issue #44370. I fixed skew helper to correctly handle case if .0 release created and there are no patch releases yet
How to test:
data/releases/schedule.yaml
Fake release example (We need to create release without previousPatches field)