Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'skew' shortcode to determine patch version accurately #45018

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

sergeyshevch
Copy link
Member

This PR address issue #44370. I fixed skew helper to correctly handle case if .0 release created and there are no patch releases yet

How to test:

  • Add fake release to data/releases/schedule.yaml
  • Update hugo.toml with fake release
  • Preview docs

Fake release example (We need to create release without previousPatches field)

- release: 1.30
  releaseDate: 2023-12-13
  next:
    release: 1.29.2
    cherryPickDeadline: 2024-02-09
    targetDate: 2024-02-14
  maintenanceModeStartDate: 2024-12-28
  endOfLifeDate: 2025-02-28

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 4, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kbhawkey February 4, 2024 17:53
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2024
Copy link

netlify bot commented Feb 4, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b4b3826
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65bfcf07bd1b61000841dcc2
😎 Deploy Preview https://deploy-preview-45018--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Feb 4, 2024

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Feb 4, 2024
@dipesh-rawat
Copy link
Member

/retitle Fix 'skew' shortcode to determine patch version accurately

@k8s-ci-robot k8s-ci-robot changed the title fix: Fix skew helper Fix 'skew' shortcode to determine patch version accurately Feb 5, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I've validated them on my system and they work as expected.

Additionally, I've verified the type of $currentVersion using {{ printf "%T" $currentVersion }}, confirming it returns a string, which aligns with the issue's root cause of formatting the string type text as a float. Great work!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 08ad757982081e049916e7e0b8c35a5d96aaf248

@reylejano
Copy link
Member

changes look good on my system
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit c2600bc into kubernetes:main Feb 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants