Add minimal systemd version about configuring cgroup driver docs #44979

pegasas · 2024-02-01T10:39:45Z

try to fix #44904
add minimal systemd version about configuring cgroup driver docs

k8s-ci-robot · 2024-02-01T10:40:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2024-02-01T10:42:25Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`58b154e`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65bb74f420727b000898bb2b
😎 Deploy Preview	https://deploy-preview-44979--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

utkarsh-singh1 · 2024-02-01T18:17:17Z

content/en/docs/setup/production-environment/container-runtimes.md

@@ -125,6 +125,10 @@ cgroup driver instead of `cgroupfs`.

 ### systemd cgroup driver {#systemd-cgroup-driver}

+{{< note >}}
+The minimum `systemd` version should be v228 and above, see [details](https://github.com/systemd/systemd/commit/17f62e9bd00f5fefd486475861b06d3ec6b7ee10)


Hi @pegasas, can we make it a bit new-user friendly also, like adding a document what changes are being introduced in systemD.

I can not really get your point.

If you are talking we should add some description about how systemd cgroup driver integrated into CRI, it would a large topic which deserves another issue for tracking.

If you are talking which specific change are introduced by systemd v228, I think it is unneccsary, assume if you are a user, what I concern is how I could use this function as soon as possible. If indeed the customer has such kinds of demands, he/she will looks deep into source code just like the discussions on issues.

@pegasas, thanks for the clarity, was talking about any discussion before/after about this commit you have mentioned, if there are any?

no, actually.
What are your suggestion?
maybe you're talking #1?

I agree with @utkarsh-singh1 here. Not everyone can understand the code and a purpose of certain code change. How about pointing to the systemd release notes ?

Here is how the change is explained there:

Slice units may now be created transiently via the bus APIs, similar to the way service and scope units may already be created transiently.

This is also requires some background for understanding, but it's much better than pointing to the code in my opinion.

@pegasas I would recommend linking to the systemd release notes or the releases page than pointing to the actual code. Also, a small nit

Suggested change

The minimum `systemd` version should be v228 and above, see [details](https://github.com/systemd/systemd/commit/17f62e9bd00f5fefd486475861b06d3ec6b7ee10)

The minimum `systemd` version should be v228 or above, see [details](https://github.com/systemd/systemd/releases/tag/v228)

May be some explanations should be added to clarify why the change is important for Kubernetes, wdyt?

Stating the required version should be sufficient IMO. What are some examples of the the explanations you'd like to see?

I simply want to know why v228 is a minimum required version.
Here is an example: https://kubernetes.io/docs/concepts/architecture/cgroups/#using-cgroupv2
That documentation not just recommends certain software versions, but gives enough info for a reader to understand a reasoning behind it, e.g. CRI-O >= v1.20 and Containerd >= v1.4 support cgroup2.

That's a good point. AFAIK the minimum required version is v228 per the linked issue because the kubelet fails to start with lower versions.

k8s-triage-robot · 2024-05-13T08:37:38Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-08-11T10:13:50Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

bart0sh · 2024-08-11T10:28:54Z

/remove-lifecycle stale

network-charles · 2024-10-03T09:01:54Z

content/en/docs/setup/production-environment/container-runtimes.md

@@ -125,6 +125,10 @@ cgroup driver instead of `cgroupfs`.

 ### systemd cgroup driver {#systemd-cgroup-driver}

+{{< note >}}
+The minimum `systemd` version should be v228 and above, see [details](https://github.com/systemd/systemd/commit/17f62e9bd00f5fefd486475861b06d3ec6b7ee10)


Explained why this version is important. I also pointed to the version release note as it is easier to understand than reading code written in C.

Suggested change

The minimum `systemd` version should be v228 and above, see [details](https://github.com/systemd/systemd/commit/17f62e9bd00f5fefd486475861b06d3ec6b7ee10)

To use the systemd cgroup driver, `systemd` should be version 228 or later.

Before v228, systemd wasn’t good at handling transient units for slices. Normally, systemd would statically load this from a file, so this caused problems when Kubernetes tried to create slices dynamically.

See [systemd v228 release notes](https://github.com/systemd/systemd/blob/v228/NEWS).

I'd write:

To use the systemd cgroup driver, `systemd` should be version 228 or later.

(mentioning “minimum” is tautological).

The rest of the change looks good. However, I'd move the entire note to come after we introduce systemd.

tengqm · 2024-10-27T00:02:55Z

/close
Closing due to 8+ months of inactivity. Feel free to reopen though.

k8s-ci-robot · 2024-10-27T00:03:00Z

@tengqm: Closed this PR.

In response to this:

/close
Closing due to 8+ months of inactivity. Feel free to reopen though.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

minimal systemd version about configuring cgroup driver docs

58b154e

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 1, 2024

k8s-ci-robot requested a review from bart0sh February 1, 2024 10:40

k8s-ci-robot requested a review from vincepri February 1, 2024 10:40

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 1, 2024

utkarsh-singh1 reviewed Feb 1, 2024

View reviewed changes

k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 13, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2024

network-charles reviewed Oct 3, 2024

View reviewed changes

k8s-ci-robot closed this Oct 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add minimal systemd version about configuring cgroup driver docs #44979

Add minimal systemd version about configuring cgroup driver docs #44979

pegasas commented Feb 1, 2024

k8s-ci-robot commented Feb 1, 2024

netlify bot commented Feb 1, 2024

utkarsh-singh1 Feb 1, 2024

pegasas Feb 6, 2024 •

edited

Loading

utkarsh-singh1 Feb 13, 2024 •

edited

Loading

pegasas May 13, 2024

bart0sh Aug 11, 2024

divya-mohan0209 Aug 14, 2024

bart0sh Aug 14, 2024

divya-mohan0209 Aug 14, 2024

bart0sh Aug 14, 2024

divya-mohan0209 Aug 14, 2024

k8s-triage-robot commented May 13, 2024

k8s-triage-robot commented Aug 11, 2024

bart0sh commented Aug 11, 2024

network-charles Oct 3, 2024 •

edited

Loading

sftim Oct 3, 2024

network-charles Oct 3, 2024

tengqm commented Oct 27, 2024

k8s-ci-robot commented Oct 27, 2024

	The minimum `systemd` version should be v228 and above, see [details](https://github.com/systemd/systemd/commit/17f62e9bd00f5fefd486475861b06d3ec6b7ee10)
	The minimum `systemd` version should be v228 or above, see [details](https://github.com/systemd/systemd/releases/tag/v228)

-The minimum `systemd` version should be v228 and above, see [details](https://github.com/systemd/systemd/commit/17f62e9bd00f5fefd486475861b06d3ec6b7ee10)
+To use the systemd cgroup driver, `systemd` should be version 228 or later.
+Before v228, systemd wasn’t good at handling transient units for slices. Normally, systemd would statically load this from a file, so this caused problems when Kubernetes tried to create slices dynamically.
+See [systemd v228 release notes](https://github.com/systemd/systemd/blob/v228/NEWS).

Add minimal systemd version about configuring cgroup driver docs #44979

Add minimal systemd version about configuring cgroup driver docs #44979

Conversation

pegasas commented Feb 1, 2024

k8s-ci-robot commented Feb 1, 2024

netlify bot commented Feb 1, 2024

✅ Pull request preview available for checking

Choose a reason for hiding this comment

pegasas Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

utkarsh-singh1 Feb 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-triage-robot commented May 13, 2024

k8s-triage-robot commented Aug 11, 2024

bart0sh commented Aug 11, 2024

network-charles Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tengqm commented Oct 27, 2024

k8s-ci-robot commented Oct 27, 2024

pegasas Feb 6, 2024 •

edited

Loading

utkarsh-singh1 Feb 13, 2024 •

edited

Loading

network-charles Oct 3, 2024 •

edited

Loading