Create basic structure and translate home for Arabic #44902

mboukhalfa · 2024-01-25T18:55:33Z

This PR adds the minimal translation related to the file /home/_index.md

k8s-ci-robot · 2024-01-25T18:55:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adowair · 2024-01-25T19:30:14Z

Thanks for re-opening this @mboukhalfa. I have a draft PR #44862 open for data/i18n/ar/ar.toml and your work here is vital—I will incorporate your changes here into it and credit you as co-author, in order to keep that unit of work independent.

sftim

Thanks for this work. I have some feedback you'd need to account for before we can merge this, even to a branch you're not yet publishing to the live site

avoid including any English files
let's split the important CSS change out into its own pull request, so we can make sure we merge the right thing
one of the localization strings files actually needs to be a symbolic link

/hold
I'd want to omit the change to OWNERS_ALIASES before removing the hold, and I'd want the PR to avoid including any files with substantial English text before we give this LGTM.

It's impressive, and we're here to help - with some more changes, this can land.

sftim · 2024-01-26T01:13:28Z

assets/scss/_custom.scss

+body:lang(ar) {
+  .navbar-brand {
+    left: 16px;
+  }
+  .announcement-main {
+
+    direction: ltr;
+    text-align: left;
+
+  }
+}


This change belongs in its own PR.

Ideally, make it work for all LTR languages and not just Arabic.

SIG Docs can help you make and land that PR in main so that the Arabic work can build upon it.

Hi @sftim, do you have any plans to address the LTR issue in the main branch?
Is there a possibility of implementing a solution soon?

I'm happy to support the work to complete LTR support; I don't plan to work on it all myself.

We should definitely separate it out so it can land as its own change, and into main.

I think should be fixed in https://github.com/google/docsy

sftim · 2024-01-26T01:14:17Z

content/ar/docs/concepts/overview/_index.md

+reviewers:
+- mboukhalfa
+- oxPraGa


I'd omit page-specific reviewers; they don't add much (you can manage the whole team membership instead using OWNERS files).

sftim · 2024-01-26T01:15:22Z

i18n/ar.toml

This should be a symbolic link, not a file. SIG Docs can help you make a symbolic link if you are not sure how to.

sftim · 2024-01-26T01:15:39Z

hugo.toml

If you can, avoid changing this file.

sftim · 2024-01-26T01:16:22Z

data/i18n/ar/ar.toml

Please avoid including untranslated strings. You can mark what's omitted with a comment, but don't have English text where we eventually want to see Arabic.

sftim · 2024-01-26T01:16:56Z

content/ar/docs/home/supported-doc-versions.md

This file is not in Arabic - let's not include it.

PTAL: Localize home/supported-doc-versions.md to Arabic #44698

sftim · 2024-01-26T01:18:01Z

OWNERS_ALIASES

+  sig-docs-ar-owners: # Admins for Arabic content
+    - mboukhalfa
+  sig-docs-ar-reviews: # PR reviews for Arabic content
+    - mboukhalfa


For now, omit this change.

sftim · 2024-01-26T01:21:28Z

/language ar

sftim · 2024-01-26T01:21:34Z

/area localization

sftim · 2024-01-26T01:23:42Z

Even though there is more to do, I'd like to invite reviews by people who can speak both Arabic and English.

sftim · 2024-01-26T01:26:42Z

content/ar/OWNERS

For now, omit this change (but we can help get it added once the team is up and running).

seokho-son · 2024-01-31T10:47:00Z

Hi @mboukhalfa,
As a lead in the localization subproject, I'm particularly eager to see a collaborative effort this time around, especially given the several previous attempts to initiate the Arabic version by individual contributors.

I suggest we use #44682 to rally active members for the Arabic localization. It's crucial to remember that localizing Kubernetes documents is a complex task due to the sheer volume of content. Maintaining these documents is likely more challenging than setting up the basic configuration for Arabic, and it's a task that cannot be sustained without a committed team of active contributors. (I hope to discuss with contributors who are eligible for reviewer/approver for Arabic content in #44682 . Please note that a candidate needs to be Kubernetes github organization member eventually)

With a focus on teamwork and guided steps, I'm hopeful that we will not lose our way and achieve a successful outcome together. 😉

seokho-son · 2024-01-31T10:52:42Z

cc: @a-mccarthy @natalisucks :)

seokho-son · 2024-01-31T13:26:29Z

Hi @mboukhalfa

Regarding this PR, I suggest separating some contents to simply and remove duplicated works.
- Let's remove files related with (data) i18n/ar/* i18n strings and utilize [ar] Add and localize i18n strings to Arabic #44862 from @adowair
- Let's remove content/ar/docs/home/supported-doc-versions.md and utilize Localize home/supported-doc-versions.md to Arabic #44698

(same comment here: #44682 (comment))

k8s-ci-robot · 2024-01-31T18:37:40Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa

This partial commit will add some more localizations of strings. Some of these are based on @mboukhalfa's work in kubernetes#44902. Co-authored-by: Mohammed Boukhalfa <[email protected]>

seokho-son · 2024-02-05T06:58:38Z

Hi @mboukhalfa
Please give your feedback for the above review comment. I think many Arabic localization members are waiting for your response.
If you don't have enough time, let us know. :)

seifrajhi · 2024-02-04T13:47:45Z

content/ar/docs/concepts/overview/_index.md

+- oxPraGa
+title: "ملخص"
+description: >
+  كوبرناتيز عبارة عن نظام أساسي محمول قابل للتوسيع ومفتوح المصدر لإدارة حاويات الخدمات و الإنتاج، مما يسهل الاعدادات التصريحية و التنفيذ الأتوماتيكي. يضم نظام متكامل واسع وسريع النمو. خدمات كوبرناتيز، دعم و الأدوات المتوفرة على نطاق واسع.


Can we change لإدارة حاويات الخدمات و الإنتاج to لإدارة، جدولة و تنظيم حاويات الخدمات و الإنتاج

mboukhalfa · 2024-02-05T16:01:02Z

Hi @mboukhalfa Please give your feedback for the above review comment. I think many Arabic localization members are waiting for your response. If you don't have enough time, let us know. :)

Thanks for the feedback I will address the comments ASAP and push

mboukhalfa · 2024-02-07T22:20:22Z

Close as the content was split into file by file PRs mentioned above
/close

k8s-ci-robot · 2024-02-07T22:20:28Z

@mboukhalfa: Closed this PR.

In response to this:

Close as the content was split into file by file PRs mentioned above
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Create basic structure and translate home

88d7278

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 25, 2024

k8s-ci-robot requested review from bradtopol and tengqm January 25, 2024 18:55

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 25, 2024

Merge branch 'dev-1.29-ar.1' into ar-localization-dev-1.25

bfa0b7a

sftim reviewed Jan 26, 2024

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2024

k8s-ci-robot added the language/ar Issues or PRs related to Arabic language label Jan 26, 2024

k8s-ci-robot added the area/localization General issues or PRs related to localization label Jan 26, 2024

sftim reviewed Jan 26, 2024

View reviewed changes

content/ar/OWNERS

Copy link

Contributor

sftim Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, omit this change (but we can help get it added once the team is up and running).

sftim changed the title ~~Create basic structure and translate home~~ Create basic structure and translate home for Arabic Jan 26, 2024

seokho-son mentioned this pull request Jan 31, 2024

Localize Kubernetes website into Arabic #44682

Open

16 tasks

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2024

seifrajhi reviewed Feb 5, 2024

View reviewed changes

adowair mentioned this pull request Feb 5, 2024

[ar] Add and localize i18n strings to Arabic #44862

Merged

mboukhalfa mentioned this pull request Feb 5, 2024

[ar] Translate home index to arabic #45031

Merged

nate-double-u mentioned this pull request Feb 6, 2024

Reintroduce RTL support using BSv5 RTLCSS google/docsy#1442

Closed

22 tasks

This was referenced Feb 6, 2024

[ar] Translate concepts overview index to arabic #45055

Merged

[ar] Translate index to arabic #45056

Merged

[ar] Translate ar index to arabic #45064

Merged

[ar] Translate case-studies index to arabic #45065

Merged

k8s-ci-robot closed this Feb 7, 2024

adowair mentioned this pull request Mar 16, 2024

REQUEST: New membership for adowair kubernetes/org#4831

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create basic structure and translate home for Arabic #44902

Create basic structure and translate home for Arabic #44902

mboukhalfa commented Jan 25, 2024

k8s-ci-robot commented Jan 25, 2024

adowair commented Jan 25, 2024

sftim left a comment

sftim Jan 26, 2024

seokho-son Jan 31, 2024

sftim Jan 31, 2024

sftim Jan 31, 2024

mboukhalfa Feb 6, 2024

sftim Jan 26, 2024 •

edited

Loading

sftim Jan 26, 2024

sftim Jan 26, 2024

sftim Jan 26, 2024

sftim Jan 26, 2024

seokho-son Jan 31, 2024

sftim Jan 26, 2024

sftim commented Jan 26, 2024

sftim commented Jan 26, 2024

sftim commented Jan 26, 2024

sftim Jan 26, 2024

seokho-son commented Jan 31, 2024

seokho-son commented Jan 31, 2024

seokho-son commented Jan 31, 2024

k8s-ci-robot commented Jan 31, 2024

seokho-son commented Feb 5, 2024

seifrajhi Feb 4, 2024

mboukhalfa commented Feb 5, 2024

mboukhalfa commented Feb 7, 2024

k8s-ci-robot commented Feb 7, 2024

Create basic structure and translate home for Arabic #44902

Create basic structure and translate home for Arabic #44902

Conversation

mboukhalfa commented Jan 25, 2024

k8s-ci-robot commented Jan 25, 2024

adowair commented Jan 25, 2024

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sftim Jan 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sftim commented Jan 26, 2024

sftim commented Jan 26, 2024

sftim commented Jan 26, 2024

Choose a reason for hiding this comment

seokho-son commented Jan 31, 2024

seokho-son commented Jan 31, 2024

seokho-son commented Jan 31, 2024

k8s-ci-robot commented Jan 31, 2024

seokho-son commented Feb 5, 2024

Choose a reason for hiding this comment

mboukhalfa commented Feb 5, 2024

mboukhalfa commented Feb 7, 2024

k8s-ci-robot commented Feb 7, 2024

sftim Jan 26, 2024 •

edited

Loading