Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Translate content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md into Japanese #44839

Merged
merged 9 commits into from
May 6, 2024

Conversation

Okabe-Junya
Copy link
Member

close #44778

Change List

  • Translate content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md into Japanese

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2024
@k8s-ci-robot k8s-ci-robot requested a review from bells17 January 21, 2024 15:45
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Jan 21, 2024
@k8s-ci-robot k8s-ci-robot requested a review from t-inu January 21, 2024 15:45
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2024
Copy link

netlify bot commented Jan 21, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e80dadd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6635a0d6bdcfa60008168a8a
😎 Deploy Preview https://deploy-preview-44839--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya
Copy link
Member Author

@Okabe-Junya
Copy link
Member Author

Okabe-Junya commented Jan 21, 2024

before merge this pr, need to merge #44787. (and may need to rebase)

@nasa9084
Copy link
Member

cc @kakts @atoato88

@nasa9084
Copy link
Member

/cc @kakts @atoato88

@k8s-ci-robot k8s-ci-robot requested review from atoato88 and kakts April 12, 2024 14:25
@Okabe-Junya
Copy link
Member Author

/area localization

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Apr 24, 2024
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらも大変遅くなりましたが、レビューをしました。

Okabe-Junya and others added 7 commits April 30, 2024 19:02
Co-authored-by: inukai <[email protected]>
Co-authored-by: inukai <[email protected]>
Co-authored-by: inukai <[email protected]>
Co-authored-by: inukai <[email protected]>
Co-authored-by: inukai <[email protected]>
Co-authored-by: inukai <[email protected]>
Co-authored-by: inukai <[email protected]>
@Okabe-Junya
Copy link
Member Author

@t-inu

レビューありがとうございます!コメントの確認、修正させていただいたので、再度ご確認お願いいたします

/cc t-inu
/assign @kubernetes/sig-docs-ja-owners
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot requested a review from t-inu April 30, 2024 10:07
@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 30, 2024
@Okabe-Junya
Copy link
Member Author

(お二人のどちらをアサインすれば良いのか判断できなかったので、一時的に二人ともアサインさせてください)

/assign nasa9084
/assign inductor

@inductor
Copy link
Member

inductor commented Apr 30, 2024

@Okabe-Junya Network Plugin Requirements の箇所、最新の1.30では内容が変わってそうですが、これはいつ時点での翻訳になりますか?

@Okabe-Junya
Copy link
Member Author

@inductor

PR作成が1/22なので、3ヶ月以上前のものですね。。(厳密なcommit hashを割り出した方が良いですか?)

@Okabe-Junya
Copy link
Member Author

Okabe-Junya commented Apr 30, 2024

手元でざっと調べてみると、このcommitからブランチ切ってますね、

commit 2df06423a8341e24b9210d1182c416f082df6733
Merge: 833bd9570d 602a2e0121
Author: Kubernetes Prow Robot <[email protected]>
Date:   Sat Jan 20 15:26:21 2024 +0100

    Merge pull request #44775 from asa3311/sync-zh-95
    
    [zh] sync configure-service-account horizontal-pod-autoscale-walkthrough install-kubectl-macos

なので https://github.com/kubernetes/website/tree/2df06423a8341e24b9210d1182c416f082df6733当該ファイルへのリンク)の翻訳になります

@Okabe-Junya
Copy link
Member Author

upstream/main と当該時点でのdiffとってみると ## Network Plugin Requirements の文章が消えているんですね。
翻訳も合わせて削除する形で良いかもしれないですね

diff --git a/content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md b/content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md
index cae75f99e3..089d0c4183 100644
--- a/content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md
+++ b/content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md
@@ -54,19 +54,6 @@ that plugin or [networking provider](/docs/concepts/cluster-administration/netwo
 
 ## Network Plugin Requirements
 
-For plugin developers and users who regularly build or deploy Kubernetes, the plugin may also need
-specific configuration to support kube-proxy. The iptables proxy depends on iptables, and the
-plugin may need to ensure that container traffic is made available to iptables. For example, if
-the plugin connects containers to a Linux bridge, the plugin must set the
-`net/bridge/bridge-nf-call-iptables` sysctl to `1` to ensure that the iptables proxy functions
-correctly. If the plugin does not use a Linux bridge, but uses something like Open vSwitch or
-some other mechanism instead, it should ensure container traffic is appropriately routed for the
-proxy.
-
-By default, if no kubelet network plugin is specified, the `noop` plugin is used, which sets
-`net/bridge/bridge-nf-call-iptables=1` to ensure simple configurations (like Docker with a bridge)
-work correctly with the iptables proxy.
-
 ### Loopback CNI
 
 In addition to the CNI plugin installed on the nodes for implementing the Kubernetes network

Copy link
Member

@inductor inductor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2024
@Okabe-Junya
Copy link
Member Author

friendly ping @t-inu, PTAL again

Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 75793d9696a38a09fcc7949af42f01aa81e511b2

@k8s-ci-robot k8s-ci-robot merged commit a6eacb6 into kubernetes:main May 6, 2024
6 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-44778 branch May 6, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Translate content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md into Japanese
5 participants