Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in replicalimit-param.yaml fixed. #44194

Closed
wants to merge 1 commit into from

Conversation

rohan-kapse
Copy link
Contributor

Issue fixed: The word 'namspace' had a typo and its fixed now.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sataqiu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Dec 3, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 364ba12
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/656c4b1d8cfd3d000883a018
😎 Deploy Preview https://deploy-preview-44194--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 3, 2023
@k8s-ci-robot
Copy link
Contributor

@lighteness: The label(s) kind/abc cannot be applied, because the repository doesn't have them.

In response to this:

/kind abc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added language/ar Issues or PRs related to Arabic language needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed language/ar Issues or PRs related to Arabic language kind/bug Categorizes issue or PR as related to a bug. labels Dec 3, 2023
@1000Delta
Copy link
Contributor

1000Delta commented Dec 3, 2023

Hi @rohan-kapse , thanks for your contribution, but the content of this PR is duplicated with the previous #44193, maybe you can help to review that PR?

@rohan-kapse
Copy link
Contributor Author

@1000Delta Sorry, missed on that. But, it hasn't been merged as seen now.

@kundan2707
Copy link
Contributor

Hi @rohan-kapse , thanks for your contribution, but the content of this PR is duplicated with the previous #44188, maybe you can help to review that PR?

That PR is for en content and this one for zh-cn

@kundan2707
Copy link
Contributor

Fixes: #44192

@kundan2707
Copy link
Contributor

Duplicate of #44193

@1000Delta
Copy link
Contributor

1000Delta commented Dec 3, 2023

Hi @rohan-kapse , thanks for your contribution, but the content of this PR is duplicated with the previous #44188, maybe you can help to review that PR?

That PR is for en content and this one for zh-cn

Yes, my mistake. I saw 3 PR with same content.

@windsonsea
Copy link
Member

Thank you for your contribution. However, it seems that this pull request is a duplicate of #44193. In such cases, the earlier raised PR has a precedence. Thanks for your understanding.

So this will be closed.
/close

@k8s-ci-robot
Copy link
Contributor

@windsonsea: Closed this PR.

In response to this:

Thank you for your contribution. However, it seems that this pull request is a duplicate of #44193. In such cases, the earlier raised PR has a precedence. Thanks for your understanding.

So this will be closed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants