Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alpha environment variable because feature is in beta #42891

Closed
wants to merge 1 commit into from

Conversation

ardaguclu
Copy link
Member

Since kubernetes/enhancements#3895 has been promoted to beta, environment
variable representing alpha feature enablement has become obsolete. This PR removes this from website.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from sftim and tengqm September 5, 2023 07:56
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2023
@netlify
Copy link

netlify bot commented Sep 5, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b248619
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64f6df29b36b7e0008c2b004
😎 Deploy Preview https://deploy-preview-42891--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Sep 5, 2023

Should this target main (1.28) or dev-1.29 branch?

@ardaguclu
Copy link
Member Author

Should this target main (1.28) or dev-1.29 branch?

ah, sorry. This should target to dev-1.29 branch. I'll fix it.

@ardaguclu
Copy link
Member Author

Closing this in favor of #42907;

/close

@k8s-ci-robot
Copy link
Contributor

@ardaguclu: Closed this PR.

In response to this:

Closing this in favor of #42907;

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu ardaguclu deleted the kep-3895-beta branch September 6, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants