Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate APIListChunking to GA documentation #42800

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Graduate APIListChunking to GA documentation #42800

merged 1 commit into from
Sep 15, 2023

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Aug 31, 2023 •
edited
Loading

Ref kubernetes/enhancements#365

/milestone 1.29

@k8s-ci-robot
Copy link
Contributor

@wojtek-t: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

Ref https://github.com/kubernetes/enhancements/issues/1412

/milestone 1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Aug 31, 2023
@k8s-ci-robot k8s-ci-robot requested a review from lavalamp August 31, 2023 06:23
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 31, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim August 31, 2023 06:23
@netlify
Copy link

netlify bot commented Aug 31, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit ac5112e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64f056652ad08d00082e66aa

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2023
@wojtek-t wojtek-t mentioned this pull request Aug 31, 2023
Merged
tengqm
tengqm reviewed Aug 31, 2023
View reviewed changes
content/en/docs/reference/using-api/api-concepts.md Outdated
@@ -316,17 +316,15 @@ The `content-encoding` header indicates that the response is compressed with `gz

## Retrieving large results sets in chunks

{{< feature-state for_k8s_version="v1.9" state="beta" >}}
{{< feature-state for_k8s_version="v1.29" state="ga" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{< feature-state for_k8s_version="v1.29" state="ga" >}}
{{< feature-state for_k8s_version="v1.29" state="stable" >}}

sftim
sftim reviewed Aug 31, 2023
View reviewed changes
content/en/docs/reference/using-api/api-concepts.md
Provided that you don't explicitly disable the `APIListChunking`
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/), the
Kubernetes API server supports the ability to break a single large collection request
The Kubernetes API server supports the ability to break a single large collection request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

@tengqm
Copy link
Contributor

tengqm commented Aug 31, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 783e16d46f33dc56aef6b35da248bab61243115a

@reylejano
Copy link
Member

/assign @katcosgrove

@wojtek-t
Copy link
Member Author

friendly ping - can I ask for approval?

@tengqm
Copy link
Contributor

tengqm commented Sep 15, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 413a994 into kubernetes:dev-1.29 Sep 15, 2023
@wojtek-t wojtek-t mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@sftim sftim sftim left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@tengqm tengqm

@katcosgrove katcosgrove

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@wojtek-t @k8s-ci-robot @tengqm @reylejano @sftim @katcosgrove