Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update feature gate references for ProxyTerminatingEndpoint in 1.28 #42229

Merged

Conversation

andrewsykim
Copy link
Member

Update references to feature gate ProxyTerminatingEndpoints which went GA in 1.28.

kubernetes/enhancements#1669

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jul 26, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2023
@andrewsykim
Copy link
Member Author

/assign @aojea

@netlify
Copy link

netlify bot commented Jul 26, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit fd94278
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64c1beb9dc2dee0008e2eaa6

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 26, 2023
@Rishit-dagli
Copy link
Member

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jul 26, 2023
@aojea
Copy link
Member

aojea commented Jul 26, 2023

/lgtm

I do not know the reason of the failures but it is GA in 1.28 kubernetes/kubernetes#117718 and I forget to update the docs, sorry

Thanks Andrew for following up

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b46ef73935fc201e2ab5e08bb058e29c38b32c4

@tengqm
Copy link
Contributor

tengqm commented Jul 26, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
Copy link
Member

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm, ydFu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsykim please re-push commit

@andrewsykim andrewsykim force-pushed the proxy-terminating-endpoints branch from 577a601 to fd94278 Compare July 27, 2023 00:47
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and ydFu July 27, 2023 00:47
@mengjiao-liu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6570454df4d93db3946ee81304437bdb58353ff

@k8s-ci-robot k8s-ci-robot merged commit 4d6a4c2 into kubernetes:dev-1.28 Jul 27, 2023
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
…g-endpoints

update feature gate references for ProxyTerminatingEndpoint in 1.28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants