Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubectl Linux install page to dearmor GPG public key for Debian #41339

Closed
wants to merge 1 commit into from

Conversation

guettli
Copy link
Contributor

@guettli guettli commented May 26, 2023

Without this fix you get:

Err:1 https://packages.cloud.google.com/apt kubernetes-xenial InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05
Reading package lists... Done
W: GPG error: https://packages.cloud.google.com/apt kubernetes-xenial InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05
E: The repository 'https://apt.kubernetes.io kubernetes-xenial InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.

The new line was copied from here: https://github.com/kubernetes/website/blob/main/content/en/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md?plain=1#L157

This PR is about this related issue: 41334

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels May 26, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 26, 2023
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guettli Changes look fine.

I see the bot has added do-not-merge/invalid-commit-message as the commit message has fixes#<issue number> (Blocked Keywords Guide). Would you be able to edit the commit message in order to move this PR forward?

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 26, 2023
@guettli
Copy link
Contributor Author

guettli commented May 26, 2023

@dipesh-rawat I fixed the commit message. The label was removed

@guettli guettli requested a review from dipesh-rawat May 26, 2023 17:36
@netlify
Copy link

netlify bot commented May 26, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ae3cfac
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6470ededd87d270008e5095d
😎 Deploy Preview https://deploy-preview-41339--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix. The change appears satisfactory from my perspective.
/lgtm

Deploy Preview: deploy-preview-41339-install-kubectl-linux

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2023
@sftim
Copy link
Contributor

sftim commented May 27, 2023

/retitle Update kubectl Linux install page to dearmor GPG public key for Debian

Thanks

/approve

@k8s-ci-robot k8s-ci-robot changed the title Update install-kubectl-linux.md: added gpg --dearmor Update kubectl Linux install page to dearmor GPG public key for Debian May 27, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2023
@sftim
Copy link
Contributor

sftim commented May 27, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2023
@sftim
Copy link
Contributor

sftim commented May 27, 2023

Oops. The commit message still references an issue. Could you remove that mention from the commit message description @guettli? We prefer to omit that.

/lgtm cancel
/approve cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dipesh-rawat May 27, 2023 09:22
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2023
@sftim
Copy link
Contributor

sftim commented May 27, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2023
@guettli
Copy link
Contributor Author

guettli commented May 27, 2023

@sftim if you prefer it differently, then please do it. Please take my change request and merge it, or don't. I just don't get why these rules exit. I guess it should be doable to configure GitHub so that it does not automatically closes the issue if the commit messages contains "fixes #12346789"

@sftim
Copy link
Contributor

sftim commented May 29, 2023

I guess it should be doable to configure GitHub so that it does not automatically closes the issue if the commit messages contains "fixes #12346789"

The problem isn't automatically closing the issue; it's the behavior for forks of Kubernetes.

I'll add a note to the issue that a new PR is welcome.

@sftim
Copy link
Contributor

sftim commented May 29, 2023

We merged a similar but different fix.

/close

Thank you for your work on this @guettli

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

We merged a similar but different fix.

/close

Thank you for your work on this @guettli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants