-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubectl Linux install page to dearmor GPG public key for Debian #41339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guettli Changes look fine.
I see the bot has added do-not-merge/invalid-commit-message
as the commit message has fixes#<issue number>
(Blocked Keywords Guide). Would you be able to edit the commit message in order to move this PR forward?
@dipesh-rawat I fixed the commit message. The label was removed |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fix. The change appears satisfactory from my perspective.
/lgtm
Deploy Preview: deploy-preview-41339-install-kubectl-linux
/retitle Update kubectl Linux install page to dearmor GPG public key for Debian Thanks /approve |
gpg --dearmor
/hold |
Oops. The commit message still references an issue. Could you remove that mention from the commit message description @guettli? We prefer to omit that. /lgtm cancel |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@sftim if you prefer it differently, then please do it. Please take my change request and merge it, or don't. I just don't get why these rules exit. I guess it should be doable to configure GitHub so that it does not automatically closes the issue if the commit messages contains "fixes #12346789" |
The problem isn't automatically closing the issue; it's the behavior for forks of Kubernetes. I'll add a note to the issue that a new PR is welcome. |
We merged a similar but different fix. /close Thank you for your work on this @guettli |
@sftim: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Without this fix you get:
The new line was copied from here: https://github.com/kubernetes/website/blob/main/content/en/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md?plain=1#L157
This PR is about this related issue: 41334