Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CNI plugin to list of Addons #41232

Merged
merged 1 commit into from
May 30, 2023
Merged

Add CNI plugin to list of Addons #41232

merged 1 commit into from
May 30, 2023

Conversation

mrgiles
Copy link
Contributor

@mrgiles mrgiles commented May 19, 2023

Add CNI plugin entry to list of Addons. Fixes #24627

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels May 19, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 19, 2023
@netlify
Copy link

netlify bot commented May 19, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a219b8c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6467e5a90beb3f00084fa08f
😎 Deploy Preview https://deploy-preview-41232--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mrgiles
Copy link
Contributor Author

mrgiles commented May 22, 2023

FYI @tengqm

@tengqm
Copy link
Contributor

tengqm commented May 22, 2023

/lgtm
Thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f36fb6fa3fd317649c6e4d57c1e441423c6d4fd9

sftim
sftim reviewed May 22, 2023
View reviewed changes
content/en/docs/concepts/overview/components.md
Comment on lines +127 to +129
[Network plugins](/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins) are software
components that implement the container network interface (CNI) specification. They are responsible for
allocating IP addresses to pods and enabling them to communicate with each other within the cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch out for one implication:

Because these are providing cluster-level features, namespaced resources for addons belong within the kube-system namespace.

Actually, network plugins can (and some do) live outside kube-system.
Have a think about how we'll cover that specific aspect and not mislead readers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not sure how should I address this implication @sftim. The paragraph I added is just a very brief description of CNIs, where would I add the (potential) namespace confusion clarification? Any suggestions @reylejano, @tengqm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates on this one? @sftim @tengqm @reylejano

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some CNI pointers in open PR #39890

Could be useful in future PR.

@mrgiles mrgiles requested a review from sftim May 22, 2023 19:19
@reylejano
Copy link
Member

/approve
I'll make a follow-up PR to update this page that pod(s) for CNI plugins can be outside the kube-system namespace

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1a22d90 into kubernetes:main May 30, 2023
@mrgiles mrgiles mentioned this pull request Jun 28, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismetz09 chrismetz09 chrismetz09 left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@natalisucks natalisucks Awaiting requested review from natalisucks

@sftim sftim Awaiting requested review from sftim

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention network plugins in “Kubernetes Components”
6 participants
@mrgiles @tengqm @k8s-ci-robot @reylejano @chrismetz09 @sftim