Clarify kubelet vs kubeadm default cgroupDriver options #41223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 46ac7efcdc6fd3dbe4d9d2c5b78a8a1a0389420f
|
sftim
reviewed
May 22, 2023
Comment on lines
+37
to
+38
| In v1.22 and later, if the user does not set the `cgroupDriver` field under `KubeletConfiguration`, | ||
| kubeadm defaults it to `systemd`. |
There was a problem hiding this comment.
I'd put:
Suggested change
| In v1.22 and later, if the user does not set the `cgroupDriver` field under `KubeletConfiguration`, | |
| kubeadm defaults it to `systemd`. | |
| If you do not set the `cgroupDriver` field in the kubelet configuration passed to | |
| kubeadm, then the kubeadm tool defaults the value to `systemd`. This applies to | |
| Kubernetes v1.22 through to v{{< skew latestVersion >}}. If you are running a version | |
| of Kubernetes outside that range, the behavior may be different. |
(note: use of latestVersion not currentVersion)
but if I did that, I'd put a comment (HTML comment) as a note that any revision here will need to be backported.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add links to explain the differences between the kubelet's and kubeadm default cgroupDriver. Fixes #36492