Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes version information to the kubectl cheat sheet #40912

Merged

Conversation

mrgiles
Copy link
Contributor

@mrgiles mrgiles commented May 1, 2023

Adds a comment to the kubectl cheat sheet that indicates that this is relevant for the current version of Kubernetes. Fixes #40582

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels May 1, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 1, 2023
@netlify
Copy link

netlify bot commented May 1, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ff5d7b9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/645163a36914c300089c3db4
😎 Deploy Preview https://deploy-preview-40912--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mrgiles
Copy link
Contributor Author

mrgiles commented May 1, 2023

FYI @sftim

@mrgiles mrgiles force-pushed the 40582_kubectl_cheat_sheet_version branch from ddaf45a to 4abba80 Compare May 2, 2023 03:33
@mrgiles mrgiles force-pushed the 40582_kubectl_cheat_sheet_version branch from 4abba80 to c764279 Compare May 2, 2023 04:54
@mrgiles mrgiles requested a review from dipesh-rawat May 2, 2023 06:59
@sftim
Copy link
Contributor

sftim commented May 2, 2023

/lgtm

Would be nice to omit the unrelated whitespace change

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 25baeae4f4393a3b4dc4d5b07375fa4ffd88a9b3

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim May 2, 2023 19:25
@mrgiles mrgiles requested a review from reylejano May 2, 2023 23:10
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Changes looks good.
/lgtm

Deploy Preview: deploy-preview-40912-cheatsheet

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eedaea4860b9f3f606013c1cf6db451857751771

Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mrgiles
Copy link
Contributor Author

mrgiles commented May 3, 2023

/assign @nate-double-u

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9d96787 into kubernetes:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve clarity of kubectl Cheat Sheet with version information
7 participants