Add curl download options for linux on arm64 #40887
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/docs
mrgiles
force-pushed
the
31699_linux_install
branch
from
f621d7f to
ec519e2
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/LGTM |
|
@rul3m4k3r: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Addition of instructions for both x86_64 and ARM64 in a tab layout, have effectively resolved the issue.
Deploy Preview: deploy-preview-40887-install-kubectl-linux
/lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 66b7547fac7b49ff08bd67c8a511d1415bfb7349
|
|
/assign @tengqm |
| @@ -30,28 +30,45 @@ The following methods exist for installing kubectl on Linux: | |||
|
|
|||
| 1. Download the latest release with the command: | |||
|
|
|||
| ```bash | |||
| {{< tabs name="download_binary_linux" >}} | |||
| {{< tab name="x86-64" codelang="bash" >}} | |||
There was a problem hiding this comment.
In other pages, I saw the shortcode written as {{% tab %}}, but I'm not sure which one is correct or why there are two flavors of the same thing.
There was a problem hiding this comment.
@tengqm, I've used the Tabs format that's described in the Hugo Documentation: https://kubernetes.io/docs/contribute/style/hugo-shortcodes/#tabs
If you click on the Deploy Preview link above, you will see that it renders correctly.
There was a problem hiding this comment.
The shortcode is written to work with {{< tab >}} because of a historical detail about how we migrated to Hugo.
There was a problem hiding this comment.
Which is to say this is laid out correctly. Thanks for the context @sftim.
/approve
There was a problem hiding this comment.
Nice work, @mrgiles . I tried out the commands and they all worked for me.
/lgtm
|
/assign @nate-double-u |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nate-double-u The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Adds missing curl download options for Linux on arm64 arch. Fixes #31699