Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bn] Add entries into static/_redirects for Bengali localization #40341

Merged
merged 1 commit into from
Apr 14, 2023
Merged

[bn] Add entries into static/_redirects for Bengali localization #40341

merged 1 commit into from
Apr 14, 2023

Conversation

Acesif
Copy link
Contributor

@Acesif Acesif commented Mar 27, 2023

Signed-off-by: Asif Zubayer Palak [email protected]
Adds entries to static/_redirects for Bengali localization
This is an initial PR as may need some improvements!
Tracking issue: #31677

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2023
@mitul3737
Copy link
Member

/language bn

@k8s-ci-robot k8s-ci-robot added the language/bn Issues or PRs related to Bengali language label Mar 27, 2023
@mitul3737
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f98769073b4b1e2d0cf30d35f56004f9ff12931e

@seokho-son
Copy link
Member

I guess adding redirect for individual documents is not mandatory. But if there is a broken link in localized documents, we'd better add a redirect. As an initial stage, adding /bn/docs/home/ seems enough.

@seokho-son
Copy link
Member

/lgtm

@mitul3737
Copy link
Member

/approve

@seokho-son
Copy link
Member

Hi @natalisucks
This PR needs an approval from sig-docs-en-owners. PTAL :)

@natalisucks
Copy link
Contributor

/approve

@mitul3737
Copy link
Member

Hi @natalisucks
This PR needs an approval from sig-docs-en-owners. PTAL :)
Moreover, the previous approval was stuck due to the release of the 1.27 version ( #40601 )

@natalisucks
Copy link
Contributor

/approve

1 similar comment
@sftim
Copy link
Contributor

sftim commented Apr 14, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@sftim
Copy link
Contributor

sftim commented Apr 14, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mitul3737, natalisucks, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ed71ce0 into kubernetes:dev-1.23-bn.1 Apr 14, 2023
@mitul3737 mitul3737 mentioned this pull request Apr 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitul3737 mitul3737 mitul3737 approved these changes

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@seokho-son seokho-son

@mitul3737 mitul3737

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/bn Issues or PRs related to Bengali language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Acesif @mitul3737 @k8s-ci-robot @seokho-son @natalisucks @sftim