Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for mutable scheduling directives on gated Pods #40000

Merged
merged 6 commits into from
Apr 3, 2023
Merged

Add docs for mutable scheduling directives on gated Pods #40000

merged 6 commits into from
Apr 3, 2023

Conversation

danielvegamyhre
Copy link
Member

Placeholder PR for docs on mutable pod/node affinity/selector (implemented in kubernetes/kubernetes#116160)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2023
@danielvegamyhre danielvegamyhre mentioned this pull request Mar 14, 2023
Closed
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 14, 2023
@sftim
Copy link
Contributor

sftim commented Mar 14, 2023

/retitle [WIP] Add docs for mutable scheduling directives on gated Pods

/sig scheduling

@k8s-ci-robot k8s-ci-robot changed the title Docs for mutable pod/node affinity/selector [WIP] Add docs for mutable scheduling directives on gated Pods Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 14, 2023
@netlify
Copy link

netlify bot commented Mar 14, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6f8b6df
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6425c37537392d0008b45eaa
😎 Deploy Preview https://deploy-preview-40000--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielvegamyhre danielvegamyhre mentioned this pull request Mar 14, 2023
Closed
4 tasks
@danielvegamyhre danielvegamyhre force-pushed the mutable-scheduling-directives-docs branch from 3e1173c to 83c7c82 Compare March 27, 2023 18:45
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2023
@danielvegamyhre danielvegamyhre force-pushed the mutable-scheduling-directives-docs branch from 83c7c82 to 21427fb Compare March 27, 2023 19:02
@danielvegamyhre
Copy link
Member Author

@alculquicondor This is ready for a technical review. I referred to the KEP for the language describing the rules for modifying node selector, node affinity etc.

@danielvegamyhre danielvegamyhre changed the title [WIP] Add docs for mutable scheduling directives on gated Pods Add docs for mutable scheduling directives on gated Pods Mar 27, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2023
@danielvegamyhre
Copy link
Member Author

@alculquicondor Thanks for the review, I've addressed your comments and this is ready for another look

@danielvegamyhre
Copy link
Member Author

@alculquicondor I included your most recent suggestions

alculquicondor
alculquicondor reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from sig-scheduling

@reylejano
Copy link
Member

Since this PR is associated with the 1.27 release, this should target the dev-1.27 branch. The author should edit the PR and change the target to dev-1.27
/milestone 1.27

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 31, 2023
@danielvegamyhre danielvegamyhre changed the base branch from main to dev-1.27 March 31, 2023 21:13
@danielvegamyhre
Copy link
Member Author

Thanks @reylejano I updated the base to dev-1.27

@netlify
Copy link

netlify bot commented Apr 1, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 3a85a5c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6428aa79f7b8d800081b800b

@tengqm
Copy link
Contributor

tengqm commented Apr 3, 2023

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 3, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 05442d188d41adab3f9a0954daf777e2f123c50b

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit a6d1ec9 into kubernetes:dev-1.27 Apr 3, 2023
@danielvegamyhre danielvegamyhre deleted the mutable-scheduling-directives-docs branch April 3, 2023 15:46
DonatoHorn pushed a commit to DonatoHorn/website that referenced this pull request Jun 25, 2023
@danielvegamyhre @alculquicondor
@tengqm @DonatoHorn
Add docs for mutable scheduling directives on gated Pods (kubernetes#…
27bfb46 
…40000)

* initial commit

* address comments

* Update content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md

Co-authored-by: Aldo Culquicondor <[email protected]>

* adjust phrasing

* Update content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md

Co-authored-by: Qiming Teng <[email protected]>

* Update content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md

Co-authored-by: Qiming Teng <[email protected]>

---------

Co-authored-by: Aldo Culquicondor <[email protected]>
Co-authored-by: Qiming Teng <[email protected]>
@jongwooo jongwooo mentioned this pull request Jul 22, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@tengqm tengqm tengqm left review comments

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
6 participants
@danielvegamyhre @sftim @reylejano @tengqm @k8s-ci-robot @alculquicondor