Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Blog Post for KEP-3202 beta (CVE feed) #39644

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Add Blog Post for KEP-3202 beta (CVE feed) #39644

merged 4 commits into from
Apr 12, 2023

Conversation

cailyn-codes
Copy link
Contributor

@cailyn-codes cailyn-codes commented Feb 24, 2023 •
edited
Loading

This is a PR for the blog post explaining the updates to the Auto-refreshing Official CVE feed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2023
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Feb 24, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim February 24, 2023 01:00
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2023
@netlify
Copy link

netlify bot commented Feb 24, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit edbc922
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63f80c15071c670008d5dbf0
😎 Deploy Preview https://deploy-preview-39644--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 24, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9411b28
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6435c0d56a14130008814373
😎 Deploy Preview https://deploy-preview-39644--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2023
@PushkarJ
Copy link
Member

Thank you so much for getting on this and creating a wonderful draft @cailynse :)

/sig security

@k8s-ci-robot k8s-ci-robot added the sig/security Categorizes an issue or PR as relevant to SIG Security. label Feb 24, 2023
@mtardy
Copy link
Member

mtardy commented Mar 14, 2023

Thanks a lot for the draft and placeholder work! Now, most of the changes are merged, let's write the blog :)

@PushkarJ PushkarJ mentioned this pull request Mar 14, 2023
Open
14 tasks
PushkarJ
PushkarJ suggested changes Mar 14, 2023
View reviewed changes
Copy link
Member

@PushkarJ PushkarJ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for completeness

@mtardy
Copy link
Member

mtardy commented Mar 17, 2023

Hey cailyne, I cannot push to this PR (of course), so could you do a rebase of this branch on main? This branch is pre-cve feed fix and other fixes which prevent it to build locally. I can fix my local copy of your branch but not the remote. If you use gh and git it looks like this:

gh repo sync caylinse/website
git checkout main && git fetch && git pull origin main
git checkout KEP-3202-blog && git rebase main
git push origin KEP-3202-blog --force-with-lease

mtardy
mtardy reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this, he are my suggestions for organization and the content that you can hopefully directly apply from GitHub as a batch!

content/en/blog/_posts/2023-03-08-Updates-to-the-Auto-refreshing-Official-CVE-Feed/index.md Outdated
---
layout: blog
title: Updates to the Auto-refreshing Official CVE Feed
date: 2023-02-08
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder that we will have to update this on publication.

@mtardy
Copy link
Member

mtardy commented Mar 17, 2023

If you prefer applying a git patch instead of clicking all these buttons you can git apply this thing.
mahe_review.txt

@PushkarJ
Copy link
Member

@cailynse please tag me when you are able to make updates to dates as suggested by @harshitasao on the file name and metadata.

Happy to /lgtm after that!

@cailyn-codes
Copy link
Contributor Author

@cailynse please tag me when you are able to make updates to dates as suggested by @harshitasao on the file name and metadata.

Happy to /lgtm after that!

@PushkarJ - should the date be set to the deadline, April 4th? Or before?

@PushkarJ
Copy link
Member

Oops @cailynse you maybe right and I guess I misunderstood.

@harshitasao can you clarify which of the following is true:

do we want the blog to be "ready to merge" with /approve and /lgtm by April 4 ?

OR

Do we want just a PR open without need for any approvals or reviews by April 4? (Which is already what the blog's current state is)

OR

Is the publication date for this blog set to April 4?

@harshitasao
Copy link
Contributor

Hey @PushkarJ Sorry for the delayed response. We want just a PR open with a complete blog drafted by April 4th, which is the hard deadline, to better plan the release dates and avoid missing out. The feature blogs publication will start after the release (i.e., after April 11th). We're finalizing the publishing schedules, and I'll let you know the publication date.

@cailyn-codes
Copy link
Contributor Author

Hello @harshitasao - this PR is the complete blog - do we need to change anything?

nate-double-u
nate-double-u reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A copy edit pass with some spelling corrections in line.

@cailyn-codes cailyn-codes force-pushed the KEP-3202-blog branch 2 times, most recently from 164c183 to 8f8bdf3 Compare April 5, 2023 01:10
@harshitasao
Copy link
Contributor

Hello, Comms Lead for v1.27 here. The publication order and date for the Feature Blog series has been finalized and the tracking board is updated.

The publication date for this article is 25-04-2023 (April 25).

Thank you!

harshitasao
harshitasao reviewed Apr 11, 2023
View reviewed changes
content/en/blog/_posts/2023-04-04-Updates-to-the-Auto-refreshing-Official-CVE-Feed/index.md Outdated
---
layout: blog
title: Updates to the Auto-refreshing Official CVE Feed
date:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
date:
date: 2023-04-25

Please also change the file path to match the new date.

@PushkarJ
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73e641ac5c5ad203b70a5b0b89735ce419bbbb09

@PushkarJ
Copy link
Member

/assign @kubernetes/sig-docs-blog-owners

@PushkarJ
Copy link
Member

/assign kubernetes/sig-docs-en-reviews

@PushkarJ
Copy link
Member

/assign @sftim

@tengqm
Copy link
Contributor

tengqm commented Apr 12, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@tengqm
Copy link
Contributor

tengqm commented Apr 12, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 703ca72 into kubernetes:main Apr 12, 2023
@PushkarJ PushkarJ mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u left review comments

@mtardy mtardy mtardy left review comments

@sftim sftim sftim left review comments

@harshitasao harshitasao harshitasao left review comments

@PushkarJ PushkarJ Awaiting requested review from PushkarJ

Assignees

@PushkarJ PushkarJ

@nate-double-u nate-double-u

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/security Categorizes an issue or PR as relevant to SIG Security. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cailyn-codes @PushkarJ @mtardy @sftim @harshitasao @k8s-ci-robot @tengqm @nate-double-u