Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] sync reference/labels-annotations-taints/_index.md #38777

Closed
wants to merge 1 commit into from
Closed

[zh-cn] sync reference/labels-annotations-taints/_index.md #38777

wants to merge 1 commit into from

Conversation

gaogao101
Copy link
Contributor

Signed-off-by: Gao Qian [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language labels Jan 5, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2023
@netlify
Copy link

netlify bot commented Jan 5, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c3ee5dc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63b688000685770008f8cc63
😎 Deploy Preview https://deploy-preview-38777--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

windsonsea
windsonsea reviewed Jan 5, 2023
View reviewed changes
content/zh-cn/docs/reference/labels-annotations-taints/_index.md
<!--
Automanaged APIService objects are deleted by kube-apiserver when it has no built-in or custom resource API corresponding to the API group/version of the APIService.
-->
当 Automanaged APIService 对象没有与 APIService 的 API 组/版本对应的内置或自定义资源 API 时，
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
当 Automanaged APIService 对象没有与 APIService 的 API 组/版本对应的内置或自定义资源 API 时，
当自动托管的 APIService 对象没有内置或自定义资源 API 对应于该 APIService 的 API 组/版本时，

这样会不会通顺点

@tengqm
Copy link
Contributor

tengqm commented Jan 10, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@windsonsea
Copy link
Member

Could you include those changes recently merged? You can check details by running:

./scripts/lsync.sh content/zh-cn/docs/reference/labels-annotations-taints/_index.md

image

@Sea-n
Copy link
Member

Sea-n commented Feb 20, 2023

Hey @gaogao101,

Can you sync with the latest version?
Please run the command @windsonsea mentioned, there are PR #37928, #36399, #39122 and #39367 needs to be included.

@windsonsea
Copy link
Member

More than 2 months passed. This PR will be closed and might be taken over by other contributors. You can re-open it at any time when you are available, thanks.

@windsonsea
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@windsonsea: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windsonsea windsonsea windsonsea left review comments

@tengqm tengqm tengqm left review comments

@chenxuc chenxuc Awaiting requested review from chenxuc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaogao101 @tengqm @k8s-ci-robot @windsonsea @Sea-n