Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates to 2022-12-13-host-process-containers-ga blog #38437

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Minor updates to 2022-12-13-host-process-containers-ga blog #38437

merged 1 commit into from
Dec 12, 2022

Conversation

marosset
Copy link
Contributor

Signed-off-by: Mark Rossetti [email protected]

Here are some minor updates to the HostProcess Containers blog-post suggested in #37370

/assign @sftim @fsmunoz

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim December 12, 2022 19:20
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 12, 2022
@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2b1743c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63979d41d82fc1000865e125
😎 Deploy Preview https://deploy-preview-38437--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

@profnandaa: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sftim
sftim reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're willing to, I wonder about also changing the title to reflect that the release has happened.

Eg: title: "Kubernetes 1.26: Windows HostProcess Containers Are Generally Available"

Anyway,
/lgtm
/approve

/hold
OK to unhold if you're happy with it as it stands.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 811b0ae889bc85dcbd1678a498cb6cacaed1b6d4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: profnandaa, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2022
@marosset
Copy link
Contributor Author

If you're willing to, I wonder about also changing the title to reflect that the release has happened.

Eg: title: "Kubernetes 1.26: Windows HostProcess Containers Are Generally Available"

Anyway, /lgtm /approve

/hold OK to unhold if you're happy with it as it stands.

Updated

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2022
@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0abb751647c5ddc8c1be94b98bd8904db78bdb57

@marosset
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 07371c3 into kubernetes:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@profnandaa profnandaa profnandaa approved these changes

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@fsmunoz fsmunoz Awaiting requested review from fsmunoz

@sftim sftim Awaiting requested review from sftim

Assignees

@fsmunoz fsmunoz

@jsturtevant jsturtevant

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marosset @k8s-ci-robot @jsturtevant @profnandaa @sftim @fsmunoz