Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc for Alpha feature PodSchedulingReadiness #37675

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Doc for Alpha feature PodSchedulingReadiness #37675

merged 2 commits into from
Nov 28, 2022

Conversation

Huang-Wei
Copy link
Member

@Huang-Wei Huang-Wei commented Nov 2, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2022
@netlify
Copy link

netlify bot commented Nov 2, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 0e70ff0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6377d26cad2c3e0008ec27f2

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 2, 2022
@Huang-Wei Huang-Wei mentioned this pull request Nov 2, 2022
Closed
tengqm
tengqm reviewed Nov 3, 2022
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -158,6 +158,7 @@ different Kubernetes components.
| `PodDeletionCost` | `false` | Alpha | 1.21 | 1.21 |
| `PodDeletionCost` | `true` | Beta | 1.22 | |
| `PodHasNetworkCondition` | `false` | Alpha | 1.25 | |
| `PodSchedulingReadiness` | `false` | Alpha | 1.26 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description for this gate (at the end of this page) as we do for other features.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do. For now it's a placeholder.

@sftim
Copy link
Contributor

sftim commented Nov 4, 2022

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 4, 2022
@krol3
Copy link
Contributor

krol3 commented Nov 15, 2022

Hello @Huang-Wei 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday 15th November 2022. Thank you!

This was referenced Nov 15, 2022
Merged
Merged
Open
@Huang-Wei
Copy link
Member Author

@krol3 thanks for the reminder. Will get this PR ready today.

@Huang-Wei Huang-Wei force-pushed the alpha-pod-scheduling-readiness branch from e344dc4 to 2971c00 Compare November 16, 2022 00:13
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2022
@Huang-Wei Huang-Wei marked this pull request as ready for review November 16, 2022 04:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2022
@Huang-Wei
Copy link
Member Author

This PR is ready for review: https://deploy-preview-37675--kubernetes-io-vnext-staging.netlify.app/docs/concepts/scheduling-eviction/pod-scheduling-readiness/

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2022
@Huang-Wei Huang-Wei force-pushed the alpha-pod-scheduling-readiness branch from 2971c00 to c99e22d Compare November 17, 2022 00:41
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2022
tengqm
tengqm reviewed Nov 18, 2022
View reviewed changes
content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated

The output reveals it's in `SchedulingGated` state:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```bash
```none

content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated

The output is:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```bash
```none

content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md Outdated
Given the test-pod doesn't request any CPU/memory resources, it's expected that this Pod's state get
transited from previous `SchedulingGated` to `Running`:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```bash
```none

@Huang-Wei Huang-Wei force-pushed the alpha-pod-scheduling-readiness branch from c99e22d to 0e70ff0 Compare November 18, 2022 18:43
@tengqm
Copy link
Contributor

tengqm commented Nov 19, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2022
This was referenced Nov 19, 2022
Closed
Closed
krol3
krol3 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a206f937628f6eb2c8c4790cb1d2b7e4a807028

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krol3, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 49e11ab into kubernetes:dev-1.26 Nov 28, 2022
@windsonsea windsonsea mentioned this pull request Nov 28, 2022
Merged
@Huang-Wei Huang-Wei deleted the alpha-pod-scheduling-readiness branch November 28, 2022 17:55
@sftim
Copy link
Contributor

sftim commented Dec 5, 2022

It looks like we could also update https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/ to specifically mention scheduling readiness.

https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-has-network is a similar section that already exists.

This change could land after the v1.26 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@krol3 krol3 krol3 approved these changes

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@bradtopol bradtopol Awaiting requested review from bradtopol

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@krol3 krol3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
5 participants
@Huang-Wei @sftim @krol3 @tengqm @k8s-ci-robot