Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post for FSGroup on mount #37621

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Add blog post for FSGroup on mount #37621

merged 1 commit into from
Dec 13, 2022

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Oct 31, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2022
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Oct 31, 2022
@k8s-ci-robot k8s-ci-robot requested a review from onlydole October 31, 2022 12:09
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2022
@netlify
Copy link

netlify bot commented Oct 31, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3a8065c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/639359633372c20009bc3fd5
😎 Deploy Preview https://deploy-preview-37621--kubernetes-io-main-staging.netlify.app/blog/2022/12/23/kubernetes-12-06-fsgroup-on-mount
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@krol3 krol3 mentioned this pull request Nov 9, 2022
Closed
12 tasks
@bradmccoydev
Copy link
Member

Hello @bertinatto! v1.26 Comms shadow here. This feature blog is on a feature tracked for release, the deadline for submitting a draft is the 29th of November; this should be considered the hard limit since we will need to review/edit/discuss the draft, so if at all possible it's better to submit it earlier to avoid any problems.

Any doubts, we're here to help! cc @fsmunoz

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2022
@bertinatto bertinatto changed the title [WIP] Add blog post for FSGroup on mount Add blog post for FSGroup on mount Nov 23, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2022
@bertinatto
Copy link
Member Author

Note: I removed the WIP from the title, but tomorrow I'll take another pass and potentially improve a few things.

@bradmccoydev
Copy link
Member

Thanks @bertinatto looking great so far!

@bertinatto bertinatto force-pushed the fsgroup-on-mount branch 2 times, most recently from 79b2c26 to ba92d52 Compare November 28, 2022 11:04
@bertinatto
Copy link
Member Author

/assign @gnufied @xing-yang

@bertinatto bertinatto force-pushed the fsgroup-on-mount branch 2 times, most recently from 649e9f5 to f1cebda Compare November 29, 2022 13:54
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 30, 2022

Hello, Comms Lead for v1.26 here: this Feature Blog PR is confirmed for the post-release Feature Blog series. We will add the publishing date in the next days. Thank you for your work!

@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 3, 2022

Hello, Comms Lead for v1.26 here. The publication order and date for the Feature Blog series has been finalised and the tracking board updated (cf. discussion).

The publication date for this article is 23-12-2022 (December 23).

Thanks!

@xing-yang
Copy link
Contributor

General content looks good. Just a small comment.

@sftim
Copy link
Contributor

sftim commented Dec 9, 2022

Thanks
It'd be good to get a tech review / signoff - for example, from @gnufied ?

@sftim
Copy link
Contributor

sftim commented Dec 9, 2022

#37621 (comment) looks good enough for me, mind.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14ea163661455dcaf4e1767717c6985f50d6c43b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 9, 2022
@bertinatto
Copy link
Member Author

#37621 (comment) looks good enough for me, mind.

/lgtm /approve

Thank you very much for your review, @sftim!

Since I've accepted your last suggestion to change the title, the PR lost the lgtm label.

@sftim
Copy link
Contributor

sftim commented Dec 9, 2022

Easy to fix
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6870824fb0e170c26ee9ef45f31ce058a2acac7a

@sftim
Copy link
Contributor

sftim commented Dec 9, 2022

/label tide/merge-method-squash

If you squash to 1 commit and keep the same merge base, this repo preserves the LGTM.

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 9, 2022
@sftim
Copy link
Contributor

sftim commented Dec 11, 2022

/remove-label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 11, 2022
divya-mohan0209
divya-mohan0209 reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit & suggestion. Rest LGTM!

content/en/blog/_posts/2022-12-23-fsgroup-on-mount.md

## How do I use it?

This feature should be mostly transparent to users. If you maintain a CSI driver that should
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
This feature should be mostly transparent to users. If you maintain a CSI driver that should
This feature should be mostly transparent to users. If you maintain a CSI driver that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an addition, if all CSI drivers don't support this, do we want to link to a supported list?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSI drivers are third party software. Unless https://landscape.cncf.io/ covers them, there probably isn't any definitive list.

content/en/blog/_posts/2022-12-23-fsgroup-on-mount.md
## How do I use it?

This feature should be mostly transparent to users. If you maintain a CSI driver that should
support this feature, read
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
support this feature, read
supports this feature, read

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“should support” looks idiomatic to me.

@sftim sftim dismissed their stale review December 13, 2022 11:48

Fixes are in

@sftim
Copy link
Contributor

sftim commented Dec 13, 2022

I'm happy to see this merge.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 81407aa into kubernetes:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

@gnufied gnufied Awaiting requested review from gnufied

@sftim sftim Awaiting requested review from sftim

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@gnufied gnufied

@xing-yang xing-yang

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bertinatto @bradmccoydev @fsmunoz @xing-yang @sftim @k8s-ci-robot @gnufied @divya-mohan0209