Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: node: cpumanager goes GA #37435

Merged
merged 1 commit into from
Dec 13, 2022
Merged

blog: node: cpumanager goes GA #37435

merged 1 commit into from
Dec 13, 2022

Conversation

ffromani
Copy link
Contributor

Assuming that the feature goes into 1.26 as GA, this will become a blog post about it.

Enhancement: kubernetes/enhancements#3570

Signed-off-by: Francesco Romani [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2022
@ffromani ffromani changed the title blog: node: cpumanager goes GA! WIP: blog: node: cpumanager goes GA! Oct 21, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@ffromani
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 21, 2022
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 21, 2022
@ffromani ffromani mentioned this pull request Oct 21, 2022
Closed
4 tasks
@netlify
Copy link

netlify bot commented Oct 21, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a39876c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6390b726753e9100082ae12f
😎 Deploy Preview https://deploy-preview-37435--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@harshitasao
Copy link
Contributor

Hi @fromanirh , v1.26 Comms Shadow here. This feature blog is on a feature tracked for release, the deadline for submitting a draft is the 29th of November, this should be considered the hard limit since we will need to review/edit/discuss the draft, so if at all possible it's better to submit it earlier to avoid any problems.

Any doubts, we're here to help!

@ffromani
Copy link
Contributor Author

Hi @fromanirh , v1.26 Comms Shadow here. This feature blog is on a feature tracked for release, the deadline for submitting a draft is the 29th of November, this should be considered the hard limit since we will need to review/edit/discuss the draft, so if at all possible it's better to submit it earlier to avoid any problems.

Any doubts, we're here to help!

Ack, thanks for the update. I plan to submit the initial draft next week (starting Monday 21)

@ffromani ffromani force-pushed the cpumanager-ga-blog-post branch from ace03b4 to afc2732 Compare November 21, 2022 17:40
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2022
@ffromani
Copy link
Contributor Author

important note for the reviewers:
I uploaded the first draft, still quite some polishing needed on my side. However, I covered all the points I wanted, so the topic and the content are pretty much there.
I opted in because I think the information here would make a good blog post for the community, but if you folks feel this is a bit too lean and prefer to merge this content with other, I don't mind at all.

@swatisehgal
Copy link
Contributor

/cc

@ffromani ffromani force-pushed the cpumanager-ga-blog-post branch from afc2732 to f170fc0 Compare November 25, 2022 13:56
@ffromani ffromani changed the title WIP: blog: node: cpumanager goes GA! blog: node: cpumanager goes GA Nov 25, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2022
@ffromani
Copy link
Contributor Author

/hold
the PR is new reviewable

@ffromani
Copy link
Contributor Author

/hold cancel
(typo in previous comment)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2022
swatisehgal
swatisehgal reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content of the blog post looks good.
Added a few comments with suggestions for minor edits (mostly nits).

@ffromani ffromani force-pushed the cpumanager-ga-blog-post branch from f170fc0 to e208604 Compare November 28, 2022 14:16
@ffromani ffromani force-pushed the cpumanager-ga-blog-post branch from e33b8ca to eecce2b Compare November 29, 2022 10:25
@ffromani
Copy link
Contributor Author

/retest

@ffromani ffromani force-pushed the cpumanager-ga-blog-post branch from eecce2b to b7fdefd Compare November 29, 2022 12:06
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 30, 2022

Hello, Comms Lead for v1.26 here: this Feature Blog PR is confirmed for the post-release Feature Blog series. We will add the publishing date in the next days. Thank you for your work!

@ffromani
Copy link
Contributor Author

ffromani commented Dec 1, 2022

Hello, Comms Lead for v1.26 here: this Feature Blog PR is confirmed for the post-release Feature Blog series. We will add the publishing date in the next days. Thank you for your work!

awesome! thank you!

@ffromani ffromani force-pushed the cpumanager-ga-blog-post branch from b7fdefd to 0d8a4b4 Compare December 2, 2022 12:27
@ffromani
Copy link
Contributor Author

ffromani commented Dec 2, 2022

/hold cancel
publication date updated per tracker board

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2022
@harshitasao
Copy link
Contributor

Hello, Comms Shadow for v1.26 here. The publication order and date for the Feature Blog series has been finalized and the tracking board updated (cf. kubernetes/sig-release#2105).
The publication date for this article is 27-12-2022 (December 27).
Thank you!

@ffromani ffromani force-pushed the cpumanager-ga-blog-post branch from 0d8a4b4 to 3f1e16b Compare December 2, 2022 13:51
@sftim
Copy link
Contributor

sftim commented Dec 2, 2022

/hold

Do not merge until Kubernetes v1.26 is actually released

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Dec 2, 2022

failure seems to be caused by timeouts. I'll retry in the coming days.

@ffromani ffromani force-pushed the cpumanager-ga-blog-post branch from 3f1e16b to e3c3741 Compare December 5, 2022 08:13
sftim
sftim reviewed Dec 6, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few more things to fix.

@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 7, 2022

@fromanirh if you could address the review comments above it would be great, with the release date being tomorrow we want to have feature blogs ready to publish ASAP. Many thanks!

@ffromani ffromani force-pushed the cpumanager-ga-blog-post branch from e3c3741 to a39876c Compare December 7, 2022 15:54
@ffromani
Copy link
Contributor Author

ffromani commented Dec 7, 2022

@fromanirh if you could address the review comments above it would be great, with the release date being tomorrow we want to have feature blogs ready to publish ASAP. Many thanks!

done, thanks for the reminder!

@harshitasao
Copy link
Contributor

Hi, Comms Shadow for v1.26 here, since this has been thoroughly reviewed and release date has been added, approving it for final publication. Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b11aedc21d2d2116e3f1a89470cce34d0fb0ced

@sftim
Copy link
Contributor

sftim commented Dec 7, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 13, 2022

Removing hold, v1.26 was released and everything else seems to be in place.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2a5045a into kubernetes:main Dec 13, 2022
@ffromani ffromani deleted the cpumanager-ga-blog-post branch December 13, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal swatisehgal left review comments

@sftim sftim sftim left review comments

@harshitasao harshitasao harshitasao requested changes

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@harshitasao harshitasao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ffromani @harshitasao @swatisehgal @fsmunoz @sftim @k8s-ci-robot