Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove release_complete string since it's unused #37384

Merged
merged 1 commit into from
Dec 21, 2022
Merged

fix: Remove release_complete string since it's unused #37384

merged 1 commit into from
Dec 21, 2022

Conversation

sergeyshevch
Copy link
Member

Removed release_complete string as discussed in #36839

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 19, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim October 19, 2022 15:49
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2022
@sergeyshevch sergeyshevch mentioned this pull request Oct 19, 2022
Closed
@sergeyshevch sergeyshevch changed the title fix: Remove release_complete string since it's unused Draft: fix: Remove release_complete string since it's unused Oct 19, 2022
@sergeyshevch sergeyshevch force-pushed the fix/36839/remove-release_complete-string branch from fd711e1 to 929dcc4 Compare October 19, 2022 15:53
@sergeyshevch sergeyshevch changed the title Draft: fix: Remove release_complete string since it's unused fix: Remove release_complete string since it's unused Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added language/pl Issues or PRs related to Polish language language/zh Issues or PRs related to Chinese language and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 19, 2022
@netlify
Copy link

netlify bot commented Oct 19, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fd711e1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63501c807f6e5c0009d07062
😎 Deploy Preview https://deploy-preview-37384--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 19, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5c2e4f4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6380d12f35a7820009b9b994
😎 Deploy Preview https://deploy-preview-37384--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rolfedh
Copy link
Contributor

rolfedh commented Oct 19, 2022

Closes #36839

@Sea-n
Copy link
Member

Sea-n commented Nov 7, 2022

Hey @sergeyshevch,

Thanks for contributing k8s website! In this repo, we limited to one language for each PR.
Please just update the en content and leave the others to native speakers to change after this PR merged.

@sergeyshevch
Copy link
Member Author

@Sea-n Hello! I will revert the other changes today.
@rolfedh FYI

@Sea-n
Copy link
Member

Sea-n commented Nov 7, 2022

Maybe you forgot to push the commits. 🙃

@sergeyshevch sergeyshevch force-pushed the fix/36839/remove-release_complete-string branch from 929dcc4 to 5c2e4f4 Compare November 25, 2022 14:29
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2022
@sergeyshevch
Copy link
Member Author

@Sea-n Huge sorry for such a delay. Updated

@tengqm
Copy link
Contributor

tengqm commented Nov 26, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d111a010a2120779ab9497bab0f520099ba617dc

@sergeyshevch
Copy link
Member Author

@Sea-n What I need to do for finishing this PR? Is there any actions required from my side?

divya-mohan0209
divya-mohan0209 reviewed Dec 21, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sergeyshevch for this PR.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit a865703 into kubernetes:main Dec 21, 2022
@sergeyshevch sergeyshevch mentioned this pull request Apr 1, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@seokho-son seokho-son Awaiting requested review from seokho-son

@sftim sftim Awaiting requested review from sftim

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sergeyshevch @rolfedh @Sea-n @tengqm @k8s-ci-robot @divya-mohan0209