Updates for WindowsHostProcessContainers going to stable #37340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
k8s-ci-robot
added
sig/docs
35 tasks
sftim
reviewed
Oct 18, 2022
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
needs-rebase
marosset
force-pushed
the
hpc-stable-updates
branch
from
6b7cf24 to
ee00c9c
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
marosset
force-pushed
the
hpc-stable-updates
branch
from
ee00c9c to
ab295f2
Compare
k8s-ci-robot
added
size/L
|
/assign @brasmith-ms @jsturtevant @brasmith-ms and I are also working on a blog-post for this feature and we will include more in-depth examples in there |
|
/sig windows |
k8s-ci-robot
added
the
sig/windows
|
I will add a section about the HostProcess container base image. |
brasmith-ms
suggested changes
Nov 11, 2022
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md
Outdated
Show resolved
Hide resolved
| and the name of that local usergroup must be specified in the `runAsUserName` field in the deployment. | ||
| This will cause an new ephemeral local user account to be created, joined to the specified usergroup, | ||
| and used by the container. This provides a number a benefits including eliminating the need to manage | ||
| passwords for local user accounts. |
There was a problem hiding this comment.
Suggested change
| passwords for local user accounts. |
Signed-off-by: Mark Rossetti <[email protected]>
marosset
force-pushed
the
hpc-stable-updates
branch
from
ab295f2 to
0956df4
Compare
added! |
tengqm
reviewed
Nov 15, 2022
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
tengqm
reviewed
Nov 15, 2022
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
size/M
Co-authored-by: Brandon Smith <[email protected]> Co-authored-by: Qiming Teng <[email protected]>
k8s-ci-robot
added
size/L
jsturtevant
reviewed
Nov 15, 2022
| This will cause an new ephemeral local user account to be created, joined to the specified usergroup, | ||
| and used by the container. This provides a number a benefits including eliminating the need to manage | ||
| passwords for local user accounts. | ||
| Prior to initializing the HostProcess container, a new **ephemeral** local user account to be created and joined to the specified usergroup, from which the container is run. |
There was a problem hiding this comment.
to be really clear here, might say something like "the runtime will create an ephemeral".
", from which the container is run." is a bit award to read I think.
| passwords for local user accounts. | ||
| Prior to initializing the HostProcess container, a new **ephemeral** local user account to be created and joined to the specified usergroup, from which the container is run. | ||
| This provides a number a benefits including eliminating the need to manage passwords for local user accounts. | ||
| passwords for local user accounts. An initial HostProcess container running as a service account can be used to |
There was a problem hiding this comment.
container running as one of the built-in service account can be used to
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ee49e478433ac165b8399b09aedd84c8cc7126c8
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krol3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sftim
reviewed
Dec 3, 2022
There was a problem hiding this comment.
We should also have updated https://kubernetes.io/docs/concepts/workloads/pods/#privileged-mode-for-containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Rossetti [email protected]