Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-cn] Add horizontal-pod-autoscaler-v2.md chinese version #35125

Merged

Conversation

zhangxyjlu
Copy link
Contributor

@zhangxyjlu zhangxyjlu commented Jul 18, 2022

related: #34733 -HPA-v2
Add horizontal-pod-autoscaler-v2.md chinese version

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 18, 2022
@k8s-ci-robot k8s-ci-robot requested a review from idealhack July 18, 2022 09:18
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Jul 18, 2022
@k8s-ci-robot k8s-ci-robot requested a review from tengqm July 18, 2022 09:18
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 18, 2022
@netlify
Copy link

netlify bot commented Jul 18, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a1e5361
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62d657f1774bee0008aef7dc
😎 Deploy Preview https://deploy-preview-35125--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zhangxyjlu
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2022
@zhangxyjlu zhangxyjlu force-pushed the horizontal-pod-autoscaler-v2 branch from a1b832d to dcceb20 Compare July 18, 2022 09:45
@zhangxyjlu
Copy link
Contributor Author

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2022
@zhangxyjlu zhangxyjlu force-pushed the horizontal-pod-autoscaler-v2 branch 2 times, most recently from 0f4669f to 7ab6e90 Compare July 18, 2022 10:06
@zhangxyjlu zhangxyjlu force-pushed the horizontal-pod-autoscaler-v2 branch from 7ab6e90 to e1e9113 Compare July 19, 2022 03:40
@zhangxyjlu zhangxyjlu force-pushed the horizontal-pod-autoscaler-v2 branch 2 times, most recently from 7a71d4e to d719201 Compare July 19, 2022 06:44
@zhangxyjlu zhangxyjlu force-pushed the horizontal-pod-autoscaler-v2 branch from d719201 to a1e5361 Compare July 19, 2022 07:06
@zhangxyjlu
Copy link
Contributor Author

已修改完检视出的所有问题,感谢指导@tengqm

@tengqm
Copy link
Contributor

tengqm commented Jul 19, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@windsonsea
Copy link
Member

The preview is all right. Thanks.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 72b875163c5379b2a031d4c6561e06bc028c3f52

@k8s-ci-robot k8s-ci-robot merged commit 5b6d343 into kubernetes:main Jul 19, 2022
@zhangxyjlu zhangxyjlu deleted the horizontal-pod-autoscaler-v2 branch July 20, 2022 01:25
@Sea-n
Copy link
Member

Sea-n commented Jul 21, 2022

Hey @zhangxyjlu,

Just reminding, please avoid use fixes #xxx for umbrella issues.
We can use related: #xxx or part of: #xxx so that the umbrella issue would not be closed unintentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants