-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releng: Update release managers page for new RMA #35003
releng: Update release managers page for new RMA #35003
Conversation
Signed-off-by: Jeremy Rickard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: for consistency with the other lists, can you alpha-sort Release Manager Associates by first name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay I'm so happy for this ❤️
/lgtm
LGTM label has been added. Git tree hash: 64b1dadebae90e06c7fba58b43b5b27ea39be0a2
|
Oops sorry I hit the approval on mobile by mistake, revert for Stephens comment :) |
Signed-off-by: Jeremy Rickard <[email protected]>
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
@justaugustus @puerco should be good to review now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jeremy!
/lgtm
/approve
LGTM label has been added. Git tree hash: 278966283f211c785e515ee8c676dead2956a070
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Approval from releng subproject owner so dropping the hold /hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
In content/en/releases/release-managers.md,
/kind documentation
/assign @justaugustus @cpanato @puerco
/hold explicitly for subproject owner approval
Signed-off-by: Jeremy Rickard [email protected]