Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KubeletCredentialProvider feature state #34954

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Fix KubeletCredentialProvider feature state #34954

merged 1 commit into from
Jul 13, 2022

Conversation

Shubham82
Copy link
Contributor

This PR fixed the FEATURE STATE of KubeletCredentialProvider under Configure a kubelet image credential provider
task.

Fixes: #34953

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2022
@k8s-ci-robot k8s-ci-robot requested review from cheftako and liggitt July 12, 2022 12:26
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 12, 2022
@Shubham82 Shubham82 mentioned this pull request Jul 12, 2022
Closed
@netlify
Copy link

netlify bot commented Jul 12, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2ccbab7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62cd685af3b92f0008242978
😎 Deploy Preview https://deploy-preview-34954--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Jul 12, 2022

/retitle Fix KubeletCredentialProvider feature state

@k8s-ci-robot k8s-ci-robot changed the title Improvement: Updated FEATURE STATE of KubeletCredentialProvider. Fix KubeletCredentialProvider feature state Jul 12, 2022
kbhawkey
kbhawkey reviewed Jul 13, 2022
View reviewed changes
content/en/docs/tasks/kubelet-credential-provider/kubelet-credential-provider.md
@@ -7,7 +7,7 @@ description: Configure the kubelet's image credential provider plugin
content_type: task
---

{{< feature-state for_k8s_version="v1.20" state="alpha" >}}
{{< feature-state for_k8s_version="v1.24" state="beta" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change updates the version of the KubletCredentialProviders in the Feature Gates page,
https://deploy-preview-34954--kubernetes-io-main-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/

@kbhawkey
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 13, 2022
@kbhawkey
Copy link
Contributor

Thanks @Shubham82
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 16492871dcff18c2aceb557aa86faa2b93b4d5bc

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit af70960 into kubernetes:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@cheftako cheftako Awaiting requested review from cheftako

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect feature state data for kubelet credential provider
4 participants
@Shubham82 @sftim @kbhawkey @k8s-ci-robot