Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[es] Fix links to PodOverhead Feature Design #34943

Merged
merged 2 commits into from
Jul 17, 2022
Merged

[es] Fix links to PodOverhead Feature Design #34943

merged 2 commits into from
Jul 17, 2022

Conversation

arrase
Copy link
Contributor

@arrase arrase commented Jul 11, 2022

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 11, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: arrase / name: Juan Ezquerro LLanes (9854ca0)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 11, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @arrase!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/es Issues or PRs related to Spanish language labels Jul 11, 2022
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 11, 2022
@netlify
Copy link

netlify bot commented Jul 11, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 49cd4a2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62d2fff35312040008a18e23
😎 Deploy Preview https://deploy-preview-34943--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@raelga
Copy link
Member

raelga commented Jul 12, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2eda78bf51a04f2931930da56fd0e17c01713476

@Sea-n
Copy link
Member

Sea-n commented Jul 13, 2022

Nice catch! Thanks.

But please limit this PR to one language, and open one PR per languages after merged.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2022
@arrase arrase force-pushed the fix-podoverhead-design-link branch from 9854ca0 to f1107ec Compare July 13, 2022 13:05
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot requested a review from raelga July 13, 2022 13:05
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2022
@arrase arrase changed the title Fix links to PodOverhead Feature Design Fix links to PodOverhead Feature Design (language/es) Jul 13, 2022
@arrase
Copy link
Contributor Author

arrase commented Jul 13, 2022

@Sea-n Done :)

@arrase
Copy link
Contributor Author

arrase commented Jul 13, 2022

/check-required-labels

@arrase
Copy link
Contributor Author

arrase commented Jul 13, 2022

/remove-language pt

@k8s-ci-robot k8s-ci-robot removed the language/pt Issues or PRs related to Portuguese language label Jul 13, 2022
@arrase
Copy link
Contributor Author

arrase commented Jul 13, 2022

/remove-language ja

@k8s-ci-robot k8s-ci-robot removed the language/ja Issues or PRs related to Japanese language label Jul 13, 2022
@arrase
Copy link
Contributor Author

arrase commented Jul 13, 2022

/remove-language id

@k8s-ci-robot k8s-ci-robot removed the language/id Issues or PRs related to Indonesian language label Jul 13, 2022
@Sea-n
Copy link
Member

Sea-n commented Jul 13, 2022

Thanks, now it's ready for review!
/unhold

And the new link is correct.
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 641469abb6193e26dc63b0503296caa78a557780

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2022
@arrase arrase changed the title Fix links to PodOverhead Feature Design (language/es) [es] Fix links to PodOverhead Feature Design Jul 13, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2022
@k8s-ci-robot k8s-ci-robot requested a review from Sea-n July 16, 2022 18:14
@arrase arrase requested a review from electrocucaracha July 16, 2022 18:14
@electrocucaracha
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ad559297a138d6ab03d3a9de95a032e86ca09f2f

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8f01f92 into kubernetes:main Jul 17, 2022
@arrase arrase deleted the fix-podoverhead-design-link branch July 18, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@habibrosyad habibrosyad Awaiting requested review from habibrosyad

@raelga raelga Awaiting requested review from raelga

@Sea-n Sea-n Awaiting requested review from Sea-n

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

Assignees

@raelga raelga

@electrocucaracha electrocucaracha

@Sea-n Sea-n

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arrase @k8s-ci-robot @raelga @Sea-n @electrocucaracha