Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] branch name in 'Korean L10n guide' page is updated #34936

Merged
merged 1 commit into from
Jul 13, 2022
Merged

[ko] branch name in 'Korean L10n guide' page is updated #34936

merged 1 commit into from
Jul 13, 2022

Conversation

bishal7679
Copy link
Member

Fixes:- #34930

master branch in 'Korean L10n guide' page is updated to main branch

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2022
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 11, 2022
@netlify
Copy link

netlify bot commented Jul 11, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ebdae96
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62cc20f8ea12900008e327cf
😎 Deploy Preview https://deploy-preview-34936--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

#34930 (comment)

Hi @bishal7679
Thank you for your contribution.

But I need to say, IMO, self-assigning (and opening a PR) is not a good way to proceed handling an open issue in an open source project.
We need to check who are going to handle the issue. (especially, if you are not the author of this issue)

@jihoon-seo I hope to check your willingness first for handling this issue.

@seokho-son
Copy link
Member

/retitle [ko] branch name in 'Korean L10n guide' page is updated

@k8s-ci-robot k8s-ci-robot changed the title branch name in 'Korean L10n guide' page is updated [ko] branch name in 'Korean L10n guide' page is updated Jul 11, 2022
@jihoon-seo
Copy link
Member

For anyone's information:
Regarding @seokho-son's comment:
please see this.

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 11a2c45647a070943bcf069265358418c9143103

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2022
@seokho-son
Copy link
Member

Hi @bishal7679

Thank you for your contribution!
Korean localization uses development branch (currently, it is dev-1.24-ko.2) and are avoiding PRs to main branch to prevent conflicts.
But, I am going to approve this PR in main branch since it is a hot-fix.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1b0caae into kubernetes:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants