Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Minor Typo in Korean docs fixed #34932

Closed
wants to merge 2 commits into from

Conversation

nitishfy
Copy link
Member

Fix: #34909

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2022
@k8s-ci-robot k8s-ci-robot requested a review from gochist July 11, 2022 11:21
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign seokho-son after the PR has been reviewed.
You can assign the PR to them by writing /assign @seokho-son in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot requested a review from yoonian July 11, 2022 11:21
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 11, 2022
@netlify
Copy link

netlify bot commented Jul 11, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8aec8d2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62d055fa4014280009b45ff7
😎 Deploy Preview https://deploy-preview-34932--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

/retitle [ko] Minor Typo in Korean docs fixed

@k8s-ci-robot k8s-ci-robot changed the title Minor Typo in Korean docs fixed [ko] Minor Typo in Korean docs fixed Jul 11, 2022
@jihoon-seo
Copy link
Member

Currently this PR is not fully reflecting the suggestions raised in #34909.

@nitishfy
Copy link
Member Author

@jihoon-seo Can you give a hint on how to push the changes to dev-1.24 branch rather than main branch

@@ -87,7 +87,7 @@ DELETE | delete(개별 리소스), deletecollection(리소스 모음)

쿠버네티스 API 서버는 몇 가지 인가 모드 중 하나를 사용하여 요청을 승인할 수 있다.

* **Node** - 실행되도록 스케줄된 파드에 따라 kubelet에게 권한을 부여하는 특수 목적 인가 모드. Node 인가 모드 사용에 대한 자세한 내용은 [Node 인가](/docs/reference/access-authn-authz/node/) 참조한다.
* **Node** - 실행되도록 스케줄된 파드에 따라 kubelet에게 권한을 부여하는 특수 목적 인가 모드. Node 인가 모드 사용에 대한 자세한 내용은 [Node 인가를](/docs/reference/access-authn-authz/node/) 참조한다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Node** - 실행되도록 스케줄된 파드에 따라 kubelet에게 권한을 부여하는 특수 목적 인가 모드. Node 인가 모드 사용에 대한 자세한 내용은 [Node 인가를](/docs/reference/access-authn-authz/node/) 참조한다.
* **Node** - 실행되도록 스케줄된 파드에 따라 kubelet에게 권한을 부여하는 특수 목적 인가 모드. Node 인가 모드 사용에 대한 자세한 내용은 [Node 인가](/docs/reference/access-authn-authz/node/) 참조한다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoonian Please look at the issue. The changes were made as described there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nitishkumar06
I checked the suggestion in the issue #34909 .
Your change [Node 인가를] seems not a part of the suggestion. (the suggestion is just about -> )

And I am sure @yoonian 's review is correct. ([Node 인가](......)를)
Please check the issue's suggestion and apply the review comment if you agree with.

@nitishfy
Copy link
Member Author

Hey @jihoon-seo Do I need to create a new PR to resolve the 2nd change since it requires to be merged in the dev-1.24-ko branch?

@seokho-son
Copy link
Member

Hi @nitishkumar06

The procedure for opening a PR for dev-1.24-ko.2 is like this ..

First of all, the base branch needs to be dev-1.24-ko.2 of upstream.
(before make changes)

For instance,

git checkout upstream/dev-1.24-ko.2
git checkout -b yourlocaldev
Apply your changes
and push it to origin repo. (as usual)

When you open a PR,
You need to select dev-1.24-ko.2 as the target base branch. (In GitHub UI)


In case of this PR,
you can close this PR and open a new PR (both base and target are dev-1.24-ko.2)
or you can update commits so that the PR include a commit which is compatible with dev-1.24-ko.2 branch. It is upto you :)

@jihoon-seo
Copy link
Member

/label tide/merge-method-squash
@nitishkumar06 Could you reflect the suggestion below within this PR, which was raised in #34909?

#2
to-be:
kubectl은 API 인증 계층을 신속하게 쿼리하기 위한 auth can-i 하위 명령어를 제공한다.

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 15, 2022
@nitishfy
Copy link
Member Author

nitishfy commented Jul 15, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ko] Minor typos in docs/reference/access-authn-authz/authorization.md
5 participants