Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced all k/website in localization guide with kubernetes/website … #34847

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Replaced all k/website in localization guide with kubernetes/website … #34847

merged 1 commit into from
Jul 12, 2022

Conversation

bishal7679
Copy link
Member

@bishal7679 bishal7679 commented Jul 6, 2022 •
edited
Loading

Mentioned PR : #34658 fully resolved via this PR

__
sema-logo  Tags: Reusable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 6, 2022
@bishal7679 bishal7679 mentioned this pull request Jul 6, 2022
Closed
@netlify
Copy link

netlify bot commented Jul 6, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e70d30
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62c57dd85e7e470008f8546e
😎 Deploy Preview https://deploy-preview-34847--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kbhawkey
Copy link
Contributor

kbhawkey commented Jul 12, 2022 •
edited
Loading

/kind cleanup

@k8s-ci-robot
Copy link
Contributor

@kbhawkey: The label(s) kind/cleanu cannot be applied, because the repository doesn't have them.

In response to this:

/kind cleanu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kbhawkey
Copy link
Contributor

Preview:
https://deploy-preview-34847--kubernetes-io-main-staging.netlify.app/docs/contribute/localization/

@kbhawkey
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 12, 2022
@kbhawkey
Copy link
Contributor

Hi @bishal7679 . Thanks for contributing.
Is this PR a replacement for PR #34658?

@kbhawkey
Copy link
Contributor

/lgtm

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9dd9d57be32f5e289ea782764ecb9e18ea7fc28c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4fb172b into kubernetes:main Jul 12, 2022
@bishal7679 bishal7679 mentioned this pull request Aug 5, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol Awaiting requested review from bradtopol

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bishal7679 @kbhawkey @k8s-ci-robot