Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]Sync content/zh-cn/docs/concepts/configuration/manage-resources-containers.md #34813

Merged
merged 1 commit into from
Jul 11, 2022
Merged

[zh-cn]Sync content/zh-cn/docs/concepts/configuration/manage-resources-containers.md #34813

merged 1 commit into from
Jul 11, 2022

Conversation

kinzhi
Copy link
Member

@kinzhi kinzhi commented Jul 4, 2022

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2022
@k8s-ci-robot k8s-ci-robot requested a review from chenrui333 July 4, 2022 17:57
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Jul 4, 2022
@k8s-ci-robot k8s-ci-robot requested a review from SataQiu July 4, 2022 17:57
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 4, 2022
@netlify
Copy link

netlify bot commented Jul 4, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c40a850
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62c32a02a7f08900089b3a95
😎 Deploy Preview https://deploy-preview-34813--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

windsonsea
windsonsea suggested changes Jul 5, 2022
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to click those links before you modify them.

content/zh-cn/docs/concepts/configuration/manage-resources-containers.md
@@ -1254,7 +1254,7 @@ for details).
-->
Pods 可用的资源量低于节点的资源总量，因为系统守护进程也会使用一部分可用资源。
在 Kubernetes API 中，每个 Node 都有一个 `.status.allocatable` 字段
（详情参见 [NodeStatus](/docs/reference/kubernetes-api/cluster-resources/node-v1/#NodeStatus)）。
（详情参见 [NodeStatus](/zh-cn/docs/reference/kubernetes-api/cluster-resources/node-v1/#NodeStatus)）。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page is still in a queue to localize. Refer to #34733. Need wait some days. Otherwise, the modification may cause 404.

content/zh-cn/docs/concepts/configuration/manage-resources-containers.md
* Read about [project quotas](https://xfs.org/docs/xfsdocs-xml-dev/XFS_User_Guide/tmp/en-US/html/xfs-quotas.html) in XFS
* Read more about the [kube-scheduler configuration reference (v1beta3)](/docs/reference/config-api/kube-scheduler-config.v1beta3/)
-->
* 获取[分配内存资源给容器和 Pod ](/zh-cn/docs/tasks/configure-pod-container/assign-memory-resource/) 的实践经验
* 获取[分配 CPU 资源给容器和 Pod ](/zh-cn/docs/tasks/configure-pod-container/assign-cpu-resource/) 的实践经验
* 阅读 API 参考中 [Container](/docs/reference/kubernetes-api/workload-resources/pod-v1/#Container)
和其[资源请求](/docs/reference/kubernetes-api/workload-resources/pod-v1/#resources)定义。
* 阅读 API 参考中 [Container](/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-v1/#Container)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be too early to change this link, which may cause 404 now. You can check all your modifications and those links by preview: https://deploy-preview-34813--kubernetes-io-main-staging.netlify.app/zh-cn/docs/concepts/configuration/manage-resources-containers/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this '/zh-cn' prefix. We'll catch up soon.
We can use the current link target without the language prefix. That's fine too.

content/zh-cn/docs/concepts/configuration/manage-resources-containers.md
@@ -1158,7 +1158,7 @@ to view the events for a Pod; for example:

如果调度器找不到该 Pod 可以匹配的任何节点，则该 Pod 将保持未被调度状态，
直到找到一个可以被调度到的位置。每当调度器找不到 Pod 可以调度的地方时，
会产生一个 [Event](/docs/reference/kubernetes-api/cluster-resources/event-v1/)。
会产生一个 [Event](/zh-cn/docs/reference/kubernetes-api/cluster-resources/event-v1/)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still in localizing. Too early to change the link.

content/zh-cn/docs/concepts/configuration/manage-resources-containers.md
* 阅读 API 参考中 [Container](/docs/reference/kubernetes-api/workload-resources/pod-v1/#Container)
和其[资源请求](/docs/reference/kubernetes-api/workload-resources/pod-v1/#resources)定义。
* 阅读 API 参考中 [Container](/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-v1/#Container)
和其[资源请求](/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-v1/#resources)定义。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need wait some days.

@windsonsea
Copy link
Member

/assign

@tengqm
Copy link
Contributor

tengqm commented Jul 11, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@my-git9
Copy link
Member

my-git9 commented Jul 11, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 987d554405e5fc472c654637f727fe5cd0b0e87f

@k8s-ci-robot k8s-ci-robot merged commit 8326d40 into kubernetes:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@windsonsea windsonsea windsonsea requested changes

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@my-git9 my-git9

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kinzhi @windsonsea @tengqm @k8s-ci-robot @my-git9