Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate content/zh-cn/docs/reference/kubernetes-api/workload-resources/cron-job-v1.md into Chinese #34748

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

sarazqy
Copy link
Contributor

@sarazqy sarazqy commented Jul 1, 2022

translate content/zh-cn/docs/reference/kubernetes-api/workload-resources/cron-job-v1.md into Chinese

Fixes #34193

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2022
@k8s-ci-robot k8s-ci-robot requested a review from chenrui333 July 1, 2022 06:45
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Jul 1, 2022
@k8s-ci-robot k8s-ci-robot requested a review from chenxuc July 1, 2022 06:45
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 1, 2022
@windsonsea
Copy link
Member

windsonsea commented Jul 1, 2022

Good job. Related to #34733. FYI:

ERROR 2022/07/19 03:19:54 [zh-cn] REF_NOT_FOUND: Ref "../workload-resources/job-v1":

Copy link
Contributor Author

@sarazqy sarazqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks to review gagin

@tengqm
Copy link
Contributor

tengqm commented Jul 8, 2022

Please mark the resolved conversations so that the reviewers don't need to double check them again.

If you don't agree to the review comments, you can counter propose a different option.

content/zh-cn/docs/reference/kubernetes-api/workload-resources/cron-job-v1.md
into Chinese
@sarazqy
Copy link
Contributor Author

sarazqy commented Jul 19, 2022

thanks to review again @tengqm

@sarazqy sarazqy requested a review from tengqm July 19, 2022 03:20
@tengqm
Copy link
Contributor

tengqm commented Jul 19, 2022

/approve
This one needs to be rebased on to 'main' once #34746 is merged.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2022

This one still depends on 'job-v1.md'.

@netlify
Copy link

netlify bot commented Jul 29, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b0d7042
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62e381df96340800083c5856
😎 Deploy Preview https://deploy-preview-34748--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarazqy sarazqy force-pushed the zqy2 branch 2 times, most recently from 38420b8 to e55a0c4 Compare July 29, 2022 06:14
@sarazqy sarazqy requested a review from zhangxyjlu July 29, 2022 06:32
@tengqm
Copy link
Contributor

tengqm commented Jul 29, 2022

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a96ae1583cac402bab648f5ccb2ab10e9e096805

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit badc615 into kubernetes:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
5 participants