Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch fix links (5) #34383

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Batch fix links (5) #34383

merged 1 commit into from
Jul 16, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jun 18, 2022

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2022
@k8s-ci-robot k8s-ci-robot requested a review from tallclair June 18, 2022 09:23
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 18, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 18, 2022
@netlify
Copy link

netlify bot commented Jun 18, 2022 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit 7b4293b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62cbbb2d25f7b100084c14e9
😎 Deploy Preview https://deploy-preview-34383--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kbhawkey
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 16, 2022
@kbhawkey
Copy link
Contributor

Changes look good. Thanks @tengqm .
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d2328e2ff9695c276ff2795d16168fc6a11d8e4a

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3238ca8 into kubernetes:main Jul 16, 2022
@tengqm tengqm deleted the fix-links-5 branch July 16, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair Awaiting requested review from tallclair

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengqm @kbhawkey @k8s-ci-robot