Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for securityContext.allowPrivilegeEscalation #34096

Closed
wants to merge 2 commits into from

Conversation

Kartik494
Copy link
Contributor

Fixes: #30104
/language en
/kind cleanup

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bradtopol after the PR has been reviewed.
You can assign the PR to them by writing /assign @bradtopol in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 1, 2022
@k8s-ci-robot k8s-ci-robot requested a review from natalisucks June 1, 2022 11:24
@Kartik494
Copy link
Contributor Author

/assign @sftim.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical nit.

@divya-mohan0209
Copy link
Contributor

/assign @sftim.

@Kartik494 : Would request that you follow the instructions as listed in this comment. I've left a review, please address that firstly.

@netlify
Copy link

netlify bot commented Jun 1, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 216085b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62975216d7bdf10009f1bef8
😎 Deploy Preview https://deploy-preview-34096--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Kartik494
Copy link
Contributor Author

/assign @bradtopol
/label tide/merge-method-squash
@divya-mohan0209 PTAL

Thanks!!

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 1, 2022
@bradtopol
Copy link
Contributor

Assigning @divya-mohan0209 since she is already engaged on this.
/unassign
/assign @divya-mohan0209

@tengqm
Copy link
Contributor

tengqm commented Jun 2, 2022

This is not supposed to be fixed here because the reference is generated from upstream source code comment. Please propose fix to the kubernetes/kubernetes repo.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that, @tengqm ! Apologies for the inconvenience, @Kartik494 . Please see this comment and consider opening an issue/PR against the k/k repository.

@divya-mohan0209
Copy link
Contributor

Closing this PR off per the previous comment

@iamNoah1
Copy link
Contributor

iamNoah1 commented Sep 6, 2022

@tengqm would this be the correct place for the improvement? If not, could you please hint to the correct place?! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value for Pod.spec.containers.securityContext.allowPrivilegeEscalation
6 participants