Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Update outdated Korean architecture/nodes #29934

Merged

Conversation

seokho-son
Copy link
Member

@seokho-son seokho-son commented Oct 5, 2021

Partially fix: #29257

  1. M2. content/ko/docs/concepts/architecture/nodes.md | 43(+M) 0(-)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 5, 2021
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 5, 2021
@seokho-son
Copy link
Member Author

@yoonian 혹시 리뷰 가능하실까요? ^^

@netlify
Copy link

netlify bot commented Oct 5, 2021

✔️ Deploy Preview for k8s-dev-ko ready!

🔨 Explore the source changes: e47542c

🔍 Inspect the deploy log: https://app.netlify.com/sites/k8s-dev-ko/deploys/615f285b5fc2fb0007727997

😎 Browse the preview: https://deploy-preview-29934--k8s-dev-ko.netlify.app

@seokho-son seokho-son changed the title Update outdated Korean architecture/nodes [ko] Update outdated Korean architecture/nodes Oct 5, 2021
@seokho-son
Copy link
Member Author

/assign @yoonian

Copy link
Contributor

@claudiajkang claudiajkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

리뷰 완료했습니다~

1.22부터는 스왑 메모리 지원을 노드 단위로 활성화할 수 있다.

노드에서 스왑을 활성화하려면, `NodeSwap` 기능 게이트가 kubelet에서
활성화되어야 하며, 명령줄 플레그 `--fail-swap-on` 또는
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
활성화되어야 하며, 명령줄 플레그 `--fail-swap-on` 또는
활성화되어야 하며, 명령줄 플래그 `--fail-swap-on` 또는

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영하였습니다! 감사합니다.. ^^

@seokho-son
Copy link
Member Author

@yoonian 님 리뷰 의견 주시면 ~ 한꺼번에 업데이트하겠습니다.. ^^

@seokho-son seokho-son force-pushed the outdate-ko-1.22-nodes branch from 465ecbb to e47542c Compare October 7, 2021 17:03
@claudiajkang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fced6e5c83a4281aa30ec666a9b380c70dbb9408

@gochist
Copy link
Member

gochist commented Oct 9, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2bf7e07 into kubernetes:dev-1.22-ko.1 Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants