Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Update outdated files in dev-1.22-ko.1 (p8) #29851

Merged
merged 1 commit into from
Oct 8, 2021
Merged

[ko] Update outdated files in dev-1.22-ko.1 (p8) #29851

merged 1 commit into from
Oct 8, 2021

Conversation

claudiajkang
Copy link
Contributor

Related issue : #29257

  1. M40. content/en/docs/reference/command-line-tools-reference/feature-gates.md | 217(+L) 68(-)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 29, 2021
@netlify
Copy link

netlify bot commented Sep 29, 2021

✔️ Deploy Preview for k8s-dev-ko ready!

🔨 Explore the source changes: ee44796

🔍 Inspect the deploy log: https://app.netlify.com/sites/k8s-dev-ko/deploys/6153da24fbf91c000758e51b

😎 Browse the preview: https://deploy-preview-29851--k8s-dev-ko.netlify.app

@netlify
Copy link

netlify bot commented Sep 29, 2021 •
edited
Loading

✔️ Deploy Preview for k8s-dev-ko ready!

🔨 Explore the source changes: da31405

🔍 Inspect the deploy log: https://app.netlify.com/sites/k8s-dev-ko/deploys/615eeeb968df9e0007cace8e

😎 Browse the preview: https://deploy-preview-29851--k8s-dev-ko.netlify.app/ko/docs/reference/command-line-tools-reference/feature-gates

@seokho-son
Copy link
Member

@jmyung 리뷰 부탁드려도 될까요? ^^

@seokho-son
Copy link
Member

/assign @jmyung

jmyung
jmyung reviewed Oct 7, 2021
View reviewed changes
Copy link
Member

@jmyung jmyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claudiajkang 고생 많으셨습니다!
퀵하게 살펴봤습니다. 👀

content/ko/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/ko/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/ko/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/ko/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/ko/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/ko/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/ko/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/ko/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/ko/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/ko/docs/reference/command-line-tools-reference/feature-gates.md Show resolved Hide resolved
@claudiajkang
Copy link
Contributor Author

@jmyung 감사합니다! 리뷰 반영하였습니다~

@jmyung
Copy link
Member

jmyung commented Oct 8, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d6b0ce0d633ad0f38c8545d16a3013601ed4fc6a

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2021
@gochist
Copy link
Member

gochist commented Oct 8, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit ffe1d46 into kubernetes:dev-1.22-ko.1 Oct 8, 2021
@seokho-son seokho-son mentioned this pull request Oct 9, 2021
Merged
@jihoon-seo jihoon-seo mentioned this pull request Oct 12, 2021
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmyung jmyung jmyung left review comments

@ianychoi ianychoi Awaiting requested review from ianychoi

@pjhwa pjhwa Awaiting requested review from pjhwa

Assignees

@jmyung jmyung

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@claudiajkang @seokho-son @jmyung @k8s-ci-robot @gochist