Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Translate tasks/inject-data-application/define-interdependent-environ… #29568

Merged
merged 1 commit into from
Aug 31, 2021
Merged

[ko] Translate tasks/inject-data-application/define-interdependent-environ… #29568

merged 1 commit into from
Aug 31, 2021

Conversation

bang9211
Copy link
Contributor

from #29277

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 27, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @bang9211!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 27, 2021
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 27, 2021
@jihoon-seo
Copy link
Member

@bang9211 안녕하세요 기여 감사합니다 😊

Netlify build log를 보면

content/ko/examples/pods/inject/dependent-envars.yaml: no such file or directory

이렇게 되어 있습니다.

  • content/en/examples/pods/inject/dependent-envars.yaml 파일을
  • content/ko/examples/pods/inject/dependent-envars.yaml 로 복사하고
  • (예제 yaml 파일에 주석이 있으면 선택적으로 번역을 하기도 하는데, 이 파일에는 주석이 없네요 😊)

  • git add <복사한 파일>
  • git commit -m "<커밋 메시지>"
  • git push origin define-interdependent-environment-variables/v0.1

이렇게 하시면 될 것 같습니다. 😊

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2021
@bang9211
Copy link
Contributor Author

bang9211 commented Aug 28, 2021

@jihoon-seo 안녕하세요. PR해놓고 지금 확인해보니 그런 문제가 있었네요

file="pods/inject/dependent-envars.yaml"

해당 파일이 주석땜에 language 별로 구분되는 줄은 몰랐습니다

감사합니다:)

@netlify
Copy link

netlify bot commented Aug 28, 2021

✔️ Deploy Preview for k8s-dev-ko ready!

🔨 Explore the source changes: 47262d1

🔍 Inspect the deploy log: https://app.netlify.com/sites/k8s-dev-ko/deploys/612db76122e26000077b27dc

😎 Browse the preview: https://deploy-preview-29568--k8s-dev-ko.netlify.app/ko/docs/tasks/inject-data-application/define-interdependent-environment-variables

@seokho-son
Copy link
Member

/assign @jihoon-seo
리뷰도 부탁드립니다~~ ;)

Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bang9211 기여 감사합니다 😊
PTAL!

@bang9211
Copy link
Contributor Author

@bang9211 기여 감사합니다 😊
PTAL!

리뷰 감사드립니다. 해당 내용 반영했습니다. :)

@jihoon-seo
Copy link
Member

@bang9211 push를 다시 하신 것 같은데, 변경사항이 반영이 되지 않은 것 같네요..
다시 한 번 확인해 주시겠어요? 😊

@bang9211
Copy link
Contributor Author

@bang9211 push를 다시 하신 것 같은데, 변경사항이 반영이 되지 않은 것 같네요..
다시 한 번 확인해 주시겠어요? 😊

번거롭게하여 죄송합니다 잘못된 branch로 되었었네요
다시 정상처리 하였습니다😅

@jihoon-seo
Copy link
Member

@bang9211 감사합니다!
/lgtm
(선택적으로, squash 해 주시면 더 좋을 것 같습니다 😊)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 033933d090009e688afc386213ef6158a81fb7d0

@seokho-son seokho-son changed the title Translate tasks/inject-data-application/define-interdependent-environ… [ko] Translate tasks/inject-data-application/define-interdependent-environ… Aug 31, 2021
@seokho-son
Copy link
Member

@bang9211 @jihoon-seo 감사합니다.. ^^

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0e5cbec into kubernetes:dev-1.22-ko.1 Aug 31, 2021
@bang9211 bang9211 deleted the bang9211/define-interdependent-environment-variables/v0.1 branch August 31, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants