Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: remove reference to the "config view" command. #28010

Merged
merged 1 commit into from
May 19, 2021
Merged

kubeadm: remove reference to the "config view" command. #28010

merged 1 commit into from
May 19, 2021

Conversation

neolit123
Copy link
Member

The command is being removed in 1.22.
Clear references to it in kubeadm-config.md.

fixes kubernetes/kubeadm#2203
xref kubernetes/kubernetes#102071

/sig cluster-lifecycle
/kind cleanup deprecation
/priority important-soon

@neolit123
kubeadm: remove reference of the "config view" command.
a41a4f9 
The command is being removed in 1.22.
Clear references to it in kubeadm-config.md.
@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone May 17, 2021
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit a41a4f9

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60a2b46abc488500073509d6

@neolit123 neolit123 mentioned this pull request May 17, 2021
Closed
2 tasks
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels May 17, 2021
@k8s-ci-robot k8s-ci-robot requested review from daminisatya and sftim May 17, 2021 18:23
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 17, 2021
@neolit123 neolit123 changed the title kubeadm: remove reference of the "config view" command. kubeadm: remove reference to the "config view" command. May 17, 2021
@neolit123
Copy link
Member Author

/cc @SataQiu

@k8s-ci-robot k8s-ci-robot requested a review from SataQiu May 17, 2021 18:23
@sftim
Copy link
Contributor

sftim commented May 18, 2021

LGTM

Maybe we should make some similar changes to the master branch too, ahead of the actual removal?

@PI-Victor
Copy link
Member

/hold for kubernetes/kubernetes#102071 to merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2021
@PI-Victor PI-Victor mentioned this pull request May 18, 2021
Open
1 task
SataQiu
SataQiu reviewed May 18, 2021
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: be73d496c55f2279e65b6395b479b13f256aa9cd

@neolit123
Copy link
Member Author

/hold cancel
kubernetes/kubernetes#102071 merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2021
@neolit123
Copy link
Member Author

@sftim

Maybe we should make some similar changes to the master branch too, ahead of the actual removal?

AFAIK, the master and dev-x branches are synced by the k/website maintainers?

@sftim
Copy link
Contributor

sftim commented May 19, 2021

AFAIK, the master and dev-x branches are synced by the k/website maintainers?

Kind of. The sync from dev-1.22 into master is a one-time merge during the release. I'm suggesting that if kubeadm config view documentation on the live site is misleading right now, we also consider fixing that on the published docs.

@neolit123
Copy link
Member Author

neolit123 commented May 19, 2021 via email

@sftim
Copy link
Contributor

sftim commented May 19, 2021

Have there been recent discussions in sig docs to switch to a more standard branch merge policy like k/k?

As I understand it, we're happy to continue with continuous delivery. We will rename master to main but throughout that the primary branch will match the published website.

sftim
sftim reviewed May 19, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 09a6795 into kubernetes:dev-1.22 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@SataQiu SataQiu SataQiu left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@neolit123 @k8sio-netlify-preview-bot @sftim @PI-Victor @k8s-ci-robot @SataQiu